Repository navigation
Conversation
The wrapper calls rejectUnsupportedWindowsArm64Runtime after the prebuilt-binary branch and before bundledBunRuntime. On win32 and arm64 it prints that Windows ARM64 is not supported by the current bundled runtime, that Bun disables TinyCC so OpenTUI cannot load, and the tracking reference oven-sh/bun#28055, then exits with status 1. The entrypoint test stubs that platform, supplies a resolvable fake bun.exe, and expects exit code 1, that stderr text, and that the fake runtime was not started. A hunkdiff patch changeset records the same message. Fixes modem-dev#1126
Contributor
|
PR author is not in the allowed authors list. |
|
@mvanhorn is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On Windows ARM64, hunk commands that open a rendered diff exit with status 1 within a fraction of a second. The only message is that the render library failed because bun:ffi dlopen is unavailable and TinyCC is disabled, and a host pane that closes on a non-zero exit hides that line before it can be read.
With no installed prebuilt selected, the launcher continues into the bundled Bun runtime and lets it start OpenTUI. On this platform Bun disables TinyCC, so that startup fails inside the runtime with the dlopen error.
What this changes
The wrapper calls rejectUnsupportedWindowsArm64Runtime after the prebuilt-binary branch and before bundledBunRuntime. On win32 and arm64 it prints that Windows ARM64 is not supported by the current bundled runtime, that Bun disables TinyCC so OpenTUI cannot load, and the tracking reference oven-sh/bun#28055, then exits with status 1. The entrypoint test stubs that platform, supplies a resolvable fake bun.exe, and expects exit code 1, that stderr text, and that the fake runtime was not started. A hunkdiff patch changeset records the same message.
Verification
./scripts/quality/source-boundaries.test.tscould not run in this environment for the hunk bundledBunRuntime change (./scripts/quality/source-boundaries.test.ts is not executable).test/cli/entrypoint.test.ts.Fixes #1126