feat: skip PNG renders whose source has not changed

brand/build/raster.py

@@ -1,21 +1,41 @@
+import hashlib
 import shutil
 import subprocess
 from pathlib import Path
 
+try:
+    from PIL import Image, PngImagePlugin
+except ModuleNotFoundError:
+    Image = PngImagePlugin = None
+
 _PNG_COLORS = 32  # palette size; flat art needs few (8 already looked clean; 32 = headroom)
+_SOURCE_KEY = "source-sha256"
+
+
+def _source_hash(svg_path: Path, width: int | None, height: int | None) -> str:
+    h = hashlib.sha256(svg_path.read_bytes())
+    h.update(f"|{width}|{height}|{_PNG_COLORS}".encode())
+    return h.hexdigest()
+
+
+def _stored_hash(png_path: Path) -> str | None:
+    if Image is None or not png_path.is_file():
+        return None
+    with Image.open(png_path) as im:
+        return im.info.get(_SOURCE_KEY)
 
 
-def _quantize_png(path: Path, colors: int = _PNG_COLORS) -> None:
+def _quantize_png(path: Path, source_hash: str, colors: int = _PNG_COLORS) -> None:
     """Re-save a PNG as an indexed-palette image — visually lossless for flat
     art. FASTOCTREE preserves alpha, so it is correct for both the opaque
     social cards and the transparent marks. No-op if Pillow is unavailable."""
-    try:
-        from PIL import Image
-    except ModuleNotFoundError:
+    if Image is None:
         return
     im = Image.open(path).convert("RGBA")
     q = im.quantize(colors=colors, method=Image.Quantize.FASTOCTREE)
-    q.save(path, format="PNG", optimize=True)
+    info = PngImagePlugin.PngInfo()
+    info.add_text(_SOURCE_KEY, source_hash)
+    q.save(path, format="PNG", optimize=True, pnginfo=info)
 
 
 def export_png(
@@ -28,12 +48,15 @@ def export_png(
     exe = shutil.which("rsvg-convert")
     if exe is None:
         return False
+    source_hash = _source_hash(svg_path, width, height)
+    if _stored_hash(png_path) == source_hash:
+        return True
     args = [exe]
     if width is not None:
         args += ["-w", str(width)]
     if height is not None:
         args += ["-h", str(height)]
     args += [str(svg_path), "-o", str(png_path)]
     subprocess.run(args, check=True)
-    _quantize_png(png_path)
+    _quantize_png(png_path, source_hash)
     return True

tests/test_raster.py

@@ -0,0 +1,55 @@
+import shutil
+from pathlib import Path
+
+import pytest
+
+from brand.build.raster import export_png
+
+pytestmark = pytest.mark.skipif(
+    shutil.which("rsvg-convert") is None, reason="rsvg-convert not installed"
+)
+
+_SVG = '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 10 10"><rect width="10" height="10" fill="{fill}"/></svg>'
+
+
+def _write_svg(path: Path, fill: str = "#c98a00") -> Path:
+    path.write_text(_SVG.format(fill=fill), encoding="utf-8")
+    return path
+
+
+def test_unchanged_source_leaves_png_untouched(tmp_path: Path) -> None:
+    """INVARIANT: re-rendering an unchanged SVG does not rewrite its PNG.
+
+    rsvg-convert builds differ byte-wise from machine to machine, so a render that
+    always rewrites turns every brand PR into a diff of every committed PNG.
+    """
+    svg = _write_svg(tmp_path / "a.svg")
+    png = tmp_path / "a.png"
+    assert export_png(svg, png, width=32, height=32)
+    before = png.read_bytes()
+    stamp = png.stat().st_mtime_ns
+
+    assert export_png(svg, png, width=32, height=32)
+    assert png.stat().st_mtime_ns == stamp
+    assert png.read_bytes() == before
+
+
+def test_changed_svg_rerenders(tmp_path: Path) -> None:
+    svg = _write_svg(tmp_path / "a.svg")
+    png = tmp_path / "a.png"
+    assert export_png(svg, png, width=32, height=32)
+    before = png.read_bytes()
+
+    _write_svg(svg, fill="#1f4d3a")
+    assert export_png(svg, png, width=32, height=32)
+    assert png.read_bytes() != before
+
+
+def test_changed_size_rerenders(tmp_path: Path) -> None:
+    svg = _write_svg(tmp_path / "a.svg")
+    png = tmp_path / "a.png"
+    assert export_png(svg, png, width=32, height=32)
+    before = png.read_bytes()
+
+    assert export_png(svg, png, width=64, height=64)
+    assert png.read_bytes() != before