Repository navigation
Fix the DR drill's replica startup race; add a never-promoted standby - #266
Merged
Merged
Conversation
Benchmark gate✅ gate passed
Gated (fails the build): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to the failover drills (
just test-dr). Neither touches library code.Replica startup race. The DR cluster sometimes came up with the replica exited. The primary's healthcheck ran
pg_isreadyover the Unix socket. That passes while the postgres entrypoint's temporary init server is up, but that server doesn't listen on TCP, so the replica'spg_basebackupgot "Connection refused". To reproduce it, I added an init script that sleeps 5s. The primary went healthy and the replica failed straight away. Withpg_isready -h 127.0.0.1, the same setup waits for the real server and the replica starts streaming. Both replicas use the TCP check too.Three-node drill. A new
pg-standbystreams from the primary and is never promoted. The drill'sasync_creatortries the hosts in the order primary, standby, replica. After failover, every connect has to reject the standby ontarget_session_attrs="primary"before it reaches the promoted replica. The drill now asserts that at least one connect was rejected by the standby and that the standby is still in recovery.Results from
just test-dr: