Repository navigation
Commit 049bfa9
fix(retry): scope streaming-body refusal note to its actual blocker site
The early-out branch for method ineligibility AND non-retryable status
also attached the streaming-body refusal note whenever `retryable_status
and request.extensions.get(STREAMING_BODY_MARKER)` — telling users their
stream couldn't replay when the actual reason for not retrying was method
exclusion (e.g. POST not in retry_methods). The same misrouting existed
on the NetworkError/TimeoutError arm.
Drop the misleading add_note() inside the early-out branches in both
AsyncRetry and Retry. The note still fires at the existing dedicated
streaming-refusal site (the `# ---- retryable failure path` block) where
streaming is the actual blocker.
Also update existing tests that exercised POST (method-ineligible) to use
PUT (method-eligible) so streaming IS the actual reason for refusal, and
flip the two non-idempotent sync tests to assert the note is NOT attached.
Closes audit Nit finding (retry.py:111 + :242/:249) from
planning/audit/2026-06-07-deep-audit.md.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 777d927 commit 049bfa9
3 files changed
Lines changed: 93 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
115 | | - | |
116 | 114 | | |
117 | 115 | | |
118 | 116 | | |
119 | 117 | | |
120 | 118 | | |
121 | | - | |
122 | | - | |
123 | 119 | | |
124 | 120 | | |
125 | 121 | | |
| |||
253 | 249 | | |
254 | 250 | | |
255 | 251 | | |
256 | | - | |
257 | | - | |
258 | 252 | | |
259 | 253 | | |
260 | 254 | | |
261 | 255 | | |
262 | 256 | | |
263 | | - | |
264 | | - | |
265 | 257 | | |
266 | 258 | | |
267 | 259 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
466 | 466 | | |
467 | 467 | | |
468 | 468 | | |
469 | | - | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
470 | 474 | | |
471 | 475 | | |
472 | 476 | | |
| |||
484 | 488 | | |
485 | 489 | | |
486 | 490 | | |
487 | | - | |
| 491 | + | |
488 | 492 | | |
489 | 493 | | |
490 | 494 | | |
| |||
493 | 497 | | |
494 | 498 | | |
495 | 499 | | |
496 | | - | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
497 | 505 | | |
498 | 506 | | |
499 | 507 | | |
| |||
510 | 518 | | |
511 | 519 | | |
512 | 520 | | |
513 | | - | |
| 521 | + | |
514 | 522 | | |
515 | 523 | | |
516 | 524 | | |
517 | 525 | | |
518 | 526 | | |
519 | 527 | | |
520 | | - | |
521 | | - | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
522 | 534 | | |
523 | 535 | | |
524 | 536 | | |
| |||
535 | 547 | | |
536 | 548 | | |
537 | 549 | | |
538 | | - | |
| 550 | + | |
539 | 551 | | |
540 | 552 | | |
541 | 553 | | |
| |||
660 | 672 | | |
661 | 673 | | |
662 | 674 | | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
181 | | - | |
182 | | - | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
183 | 187 | | |
184 | 188 | | |
185 | 189 | | |
| |||
192 | 196 | | |
193 | 197 | | |
194 | 198 | | |
195 | | - | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
196 | 202 | | |
197 | 203 | | |
198 | | - | |
199 | | - | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
200 | 210 | | |
201 | 211 | | |
202 | 212 | | |
| |||
205 | 215 | | |
206 | 216 | | |
207 | 217 | | |
208 | | - | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
209 | 221 | | |
210 | 222 | | |
211 | 223 | | |
| |||
534 | 546 | | |
535 | 547 | | |
536 | 548 | | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
0 commit comments