You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 25db15b
Browse filesBrowse the repository at this point in the historyBrowse files
- Bulkhead class docstring: replace one-liner with Parameters section so
IDE hovers carry the required-vs-default + range info.
- test_cancellation_before_acquire_does_not_hold_slot: issue a third request
WHILE first still holds the slot. Pins that the cancelled second did not
leave a phantom free slot behind.
- Add Bulkhead+Retry composition tests (test_bulkhead.py):
- test_bulkhead_outside_retry_holds_one_slot_across_attempts — pins the
documented [Bulkhead, Retry] ordering: one slot covers the whole retry
sequence (max_in_flight stays at 1 even though handler is called twice).
- test_bulkhead_full_error_is_not_retried_by_retry — pins that
BulkheadFullError (ClientError) is NOT in Retry's catch set; injected
_sleep with # pragma: no cover documents the "must never run" assertion.
Skipped one review item (#3): the BulkheadFullError summary string includes
"acquire_timeout=None" when constructed manually with None. This branch is
unreachable by design — the exception is never raised when acquire_timeout=None.
Cosmetic at best; not worth special-casing.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
0 commit comments