Skip to content

Commit 3f83216

Browse files
lesnik512claude
andcommitted
feat(story-2.3): Request.with_extension and with_extensions helpers
Adds Request.with_extension(name, value: Any) -> Self and Request.with_extensions(extensions: Mapping[str, Any]) -> Self. Extensions hold opaque user payloads (transport hints, debug attachments) — the Any value type is intentional and noqa'd. Three tests cover add-single, merge-plural, and Any-value-type behavior. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 8b865ae commit 3f83216

2 files changed

Lines changed: 33 additions & 0 deletions

File tree

‎src/httpware/request.py‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,3 +45,11 @@ def with_cookie(self, name: str, value: str) -> Self:
4545
def with_cookies(self, cookies: Mapping[str, str]) -> Self:
4646
"""Return a copy with the given cookies merged in (incoming keys override existing)."""
4747
return dataclasses.replace(self, cookies={**self.cookies, **cookies})
48+
49+
def with_extension(self, name: str, value: Any) -> Self: # noqa: ANN401
50+
"""Return a copy with the given extension entry added or replaced."""
51+
return dataclasses.replace(self, extensions={**self.extensions, name: value})
52+
53+
def with_extensions(self, extensions: Mapping[str, Any]) -> Self:
54+
"""Return a copy with the given extensions merged in (incoming keys override existing)."""
55+
return dataclasses.replace(self, extensions={**self.extensions, **extensions})

‎tests/test_request.py‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,3 +118,28 @@ def test_with_cookies_merges_new_cookies() -> None:
118118
new = r.with_cookies({"replace": "new", "add": "2"})
119119
assert new.cookies == {"keep": "1", "replace": "new", "add": "2"}
120120
assert r.cookies == {"keep": "1", "replace": "old"}
121+
122+
123+
def test_with_extension_adds_single_entry() -> None:
124+
r = Request(method="GET", url="/")
125+
new = r.with_extension("timeout", 5.0)
126+
assert new.extensions == {"timeout": 5.0}
127+
assert r.extensions == {}
128+
129+
130+
def test_with_extensions_merges_new_entries() -> None:
131+
r = Request(method="GET", url="/", extensions={"keep": 1, "replace": "old"})
132+
new = r.with_extensions({"replace": "new", "add": [1, 2]})
133+
assert new.extensions == {"keep": 1, "replace": "new", "add": [1, 2]}
134+
assert r.extensions == {"keep": 1, "replace": "old"}
135+
136+
137+
def test_with_extension_accepts_any_value_type() -> None:
138+
class _Marker:
139+
pass
140+
141+
marker = _Marker()
142+
r = Request(method="GET", url="/")
143+
new = r.with_extension("marker", marker)
144+
assert new.extensions == {"marker": marker}
145+
assert new.extensions["marker"] is marker

0 commit comments

Comments
 (0)