Skip to content

Commit 704999d

Browse files
lesnik512claude
andcommitted
feat(story-2.3): Request.with_headers merge helper
Adds Request.with_headers(headers: Mapping[str, str]) -> Self that merges the incoming mapping into the existing headers; incoming keys override existing. Four tests cover add, override, preserve-others, and empty-input semantics. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 5bcf9a4 commit 704999d

2 files changed

Lines changed: 31 additions & 0 deletions

File tree

‎src/httpware/request.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,7 @@ def with_body(self, body: bytes | None) -> Self:
3333
def with_query(self, params: Mapping[str, str]) -> Self:
3434
"""Return a copy with the given query params replacing the existing ones."""
3535
return dataclasses.replace(self, params=params)
36+
37+
def with_headers(self, headers: Mapping[str, str]) -> Self:
38+
"""Return a copy with the given headers merged in (incoming keys override existing)."""
39+
return dataclasses.replace(self, headers={**self.headers, **headers})

‎tests/test_request.py‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,3 +70,30 @@ def test_with_query_replaces_params() -> None:
7070
assert new.params == {"b": "2"}
7171
assert r.params == {"a": "1"}
7272
assert new is not r
73+
74+
75+
def test_with_headers_merges_new_headers() -> None:
76+
r = Request(method="GET", url="/")
77+
new = r.with_headers({"X-Trace": "abc", "X-Other": "1"})
78+
assert new.headers == {"X-Trace": "abc", "X-Other": "1"}
79+
assert r.headers == {}
80+
81+
82+
def test_with_headers_overrides_existing_key() -> None:
83+
r = Request(method="GET", url="/", headers={"X-Trace": "old"})
84+
new = r.with_headers({"X-Trace": "new"})
85+
assert new.headers == {"X-Trace": "new"}
86+
assert r.headers == {"X-Trace": "old"}
87+
88+
89+
def test_with_headers_preserves_other_keys() -> None:
90+
r = Request(method="GET", url="/", headers={"Keep": "1", "Replace": "old"})
91+
new = r.with_headers({"Replace": "new", "Add": "2"})
92+
assert new.headers == {"Keep": "1", "Replace": "new", "Add": "2"}
93+
94+
95+
def test_with_headers_empty_mapping_returns_distinct_copy() -> None:
96+
r = Request(method="GET", url="/", headers={"A": "1"})
97+
new = r.with_headers({})
98+
assert new == r
99+
assert new is not r

0 commit comments

Comments
 (0)