Repository navigation
Commit 79daf0c
fix(budget): ceiling uses math.ceil, not int truncation
`RetryBudget.try_withdraw`'s ceiling computed `int(deposits * percent) + floor`,
truncating so 4 deposits at percent_can_retry=0.2 yielded `int(0.8) = 0` —
the configured percentage was never reached at deposit counts below
`1/percent_can_retry`. Replace with math.ceil so the threshold is hit at the
first deposit-count where it is mathematically expressible.
The Hypothesis property test mirrored the same int() formula, so it could
not detect the off-by-one. Rewrite it to use math.ceil for the expected
ceiling and tighten `permitted <= ceiling` to `permitted == ceiling` so it
discriminates between the two roundings going forward.
Also update test_budget.py::test_deposit_after_exhaustion_does_not_immediately_unblock,
which was written to document the old truncation behaviour; the test is renamed
and rewritten to document the correct ceil semantics.
Closes audit Low findings (budget.py:67 truncation, test_budget_props.py:52
formula-mirror) from planning/audit/2026-06-07-deep-audit.md.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 14c21ab commit 79daf0c
3 files changed
Lines changed: 16 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
67 | | - | |
| 68 | + | |
68 | 69 | | |
69 | 70 | | |
70 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
73 | | - | |
| 72 | + | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
81 | 81 | | |
| 82 | + | |
82 | 83 | | |
83 | | - | |
84 | | - | |
| 84 | + | |
| 85 | + | |
85 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
86 | 90 | | |
87 | 91 | | |
88 | 92 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
63 | | - | |
| 64 | + | |
64 | 65 | | |
65 | | - | |
66 | | - | |
| 66 | + | |
| 67 | + | |
67 | 68 | | |
68 | 69 | | |
69 | | - | |
| 70 | + | |
70 | 71 | | |
71 | 72 | | |
72 | 73 | | |
| |||
0 commit comments