1010import pytest
1111
1212from httpware import ResponseDecoder
13- from httpware .decoders .pydantic import PydanticDecoder , _get_adapter
13+ from httpware .decoders .pydantic import PydanticDecoder
1414
1515
1616class User (pydantic .BaseModel ):
@@ -28,11 +28,6 @@ class UserDC:
2828 name : str
2929
3030
31- @pytest .fixture (autouse = True )
32- def _clear_adapter_cache () -> None :
33- _get_adapter .cache_clear ()
34-
35-
3631def test_pydantic_decoder_satisfies_response_decoder_protocol () -> None :
3732 assert isinstance (PydanticDecoder (), ResponseDecoder )
3833
@@ -90,7 +85,6 @@ def test_validation_error_surfaces_unchanged() -> None:
9085
9186
9287def test_cache_invariance_single_model () -> None :
93- _get_adapter .cache_clear ()
9488 with patch ("httpware.decoders.pydantic.TypeAdapter" , wraps = pydantic .TypeAdapter ) as spy :
9589 decoder = PydanticDecoder ()
9690 for _ in range (1000 ):
@@ -99,7 +93,6 @@ def test_cache_invariance_single_model() -> None:
9993
10094
10195def test_cache_invariance_two_distinct_models () -> None :
102- _get_adapter .cache_clear ()
10396 with patch ("httpware.decoders.pydantic.TypeAdapter" , wraps = pydantic .TypeAdapter ) as spy :
10497 decoder = PydanticDecoder ()
10598 for _ in range (500 ):
@@ -109,7 +102,6 @@ def test_cache_invariance_two_distinct_models() -> None:
109102
110103
111104async def test_cache_invariance_concurrent_first_calls () -> None :
112- _get_adapter .cache_clear ()
113105 with patch ("httpware.decoders.pydantic.TypeAdapter" , wraps = pydantic .TypeAdapter ) as spy :
114106 decoder = PydanticDecoder ()
115107
@@ -121,7 +113,6 @@ async def one_decode() -> User:
121113
122114
123115def test_cache_invariance_concurrent_first_calls_threadpool () -> None :
124- _get_adapter .cache_clear ()
125116 n_workers = 20
126117 with patch ("httpware.decoders.pydantic.TypeAdapter" , wraps = pydantic .TypeAdapter ) as spy :
127118 decoder = PydanticDecoder ()
@@ -133,9 +124,10 @@ def one_decode(_: int) -> User:
133124 results = list (pool .map (one_decode , range (50 )))
134125
135126 assert all (type (r ) is User and r .id == 1 for r in results )
136- # functools.lru_cache serializes the cache slot but the user function runs
137- # outside the lock — concurrent first-callers may both build a TypeAdapter
138- # before one wins (idempotent; loser is GC'd). Bounded by worker count.
127+ # `dict` reads/writes are atomic in CPython but the get→set sequence in
128+ # `_get_adapter` is not — concurrent first-callers may both build a
129+ # TypeAdapter before one wins (idempotent; loser is GC'd). Bounded by
130+ # worker count.
139131 assert 1 <= spy .call_count <= n_workers
140132
141133
@@ -144,10 +136,11 @@ def test_unhashable_model_falls_back_to_uncached_adapter() -> None:
144136
145137 When `_get_adapter` raises `TypeError` (e.g., `Annotated[int, unhashable_metadata]`),
146138 `decode` bypasses the cache so `pydantic.ValidationError` surfaces cleanly instead
147- of leaking a `functools`-internal ` TypeError` to the caller.
139+ of leaking a `TypeError` to the caller.
148140 """
149- with patch (
150- "httpware.decoders.pydantic._get_adapter" ,
141+ with patch .object (
142+ PydanticDecoder ,
143+ "_get_adapter" ,
151144 side_effect = TypeError ("unhashable type" ),
152145 ):
153146 result = PydanticDecoder ().decode (b"42" , int )
@@ -213,10 +206,8 @@ def test_pydantic_rejects_msgspec_struct() -> None:
213206
214207
215208def test_pydantic_can_decode_uses_cache () -> None :
216- _get_adapter .cache_clear ()
217209 decoder = PydanticDecoder ()
218210 decoder .can_decode (User )
219211 decoder .can_decode (User )
220- info = _get_adapter .cache_info ()
221- assert info .hits >= 1
222- assert info .misses == 1
212+ assert len (decoder ._adapters ) == 1 # noqa: SLF001
213+ assert User in decoder ._adapters # noqa: SLF001
0 commit comments