Skip to content

Commit f10f934

Browse files
lesnik512claude
andcommitted
test(circuit-breaker): tighten sync test assertions to match async parity
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent bf00d21 commit f10f934

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

‎tests/test_circuit_breaker_sync.py‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ def test_closed_passes_through() -> None:
7070
with _client(handler, breaker=breaker) as client:
7171
response = client.get("https://example.test/x")
7272
assert response.status_code == HTTPStatus.OK
73+
assert handler.calls == 1
7374

7475

7576
def test_open_emits_opened_event_and_rejects(caplog: pytest.LogCaptureFixture) -> None:
@@ -87,8 +88,14 @@ def test_open_emits_opened_event_and_rejects(caplog: pytest.LogCaptureFixture) -
8788
assert info.value.retry_after is not None
8889
assert handler.calls == 2 # noqa: PLR2004
8990
records = [r for r in caplog.records if r.name == "httpware.circuit_breaker"]
90-
assert any("opened" in r.message for r in records)
91-
assert any("rejecting" in r.message for r in records)
91+
opened = [r for r in records if "opened" in r.message]
92+
rejected = [r for r in records if "rejecting" in r.message]
93+
assert len(opened) == 1
94+
assert opened[0].failure_threshold == 2 # noqa: PLR2004 # ty: ignore[unresolved-attribute]
95+
assert opened[0].failures == 2 # noqa: PLR2004 # ty: ignore[unresolved-attribute]
96+
assert len(rejected) == 1
97+
assert rejected[0].retry_after is not None # ty: ignore[unresolved-attribute]
98+
assert rejected[0].method == "GET" # ty: ignore[unresolved-attribute]
9299

93100

94101
def test_success_resets_failure_streak() -> None:
@@ -259,5 +266,6 @@ def _probe() -> None:
259266
rejected.append(info.value)
260267
release_probe.set()
261268
thread.join(timeout=5.0)
269+
assert not thread.is_alive()
262270

263271
assert rejected[0].retry_after is None

0 commit comments

Comments
 (0)