Repository navigation
Simplify lifecycle and telemetry ownership for 2.0 - #444
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FastStream now keeps observability active through broker shutdown and user lifespan cleanup. FastStream, FastAPI, and FastMCP share the same policy for preserving a lifecycle error when teardown also fails.
OpenTelemetry rolls back resources acquired during a failed bootstrap, including failures during framework setup. Teardown preserves externally installed instrumentation and logging filters. Sentry clears its global client even when
SENTRY_DSNis set.This also removes the unused OTel exclusion helper, makes Pyroscope's additional parameters override the prepared defaults, and reports route configuration conflicts with the field to use.
Breaking changes
Code that drives FastStream through
start()/stop()orasync with applicationmust callbootstrapper.teardown()in an outerfinallyblock. The framework lifespan handles cleanup automatically. The 2.x migration guide documents both paths.Verification
Closes #434
Closes #435
Closes #436
Closes #438
Closes #440
Includes the lifecycle work from #443 with the revised manual cleanup contract.