Repository navigation
fix: youtube playback in app - #8170
Closed
jasonzli-DEV wants to merge 1 commit into
Closed
jasonzli-DEV wants to merge 1 commit into
jasonzli-DEV wants to merge 1 commit into
Conversation
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Member
|
Please do not reopen the pull request, this is the third time. We're not accepting this PR as it's not the correct way to fix this issue. |
Author
This is my second time opening this PR. The first one was closed with no response. I requested your comment to which you didn't respond, so I assumed it was closed by mistake and opened a new one. This is different than the previous ones closed for being AI-generated. If there's a way you want it done, let me know, and I can change it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the Modrinth app player where trying to view a YouTube video in a project description caused error 153. It adds the missing data via a loopback when playing videos.
This issue occurs on Mac and Linux devices but not on Windows devices.
Here are images from before and after the fix.
This also closes #5908.