Skip to content

Improve Redis timeouts - #8196

Merged
mergify[bot] merged 1 commit into
mainfrom
michael/redis-timeout
Nov 2, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
michael/redis-timeout

Conversation

@clrxbl

@clrxbl clrxbl commented Nov 2, 2026

Copy link
Copy Markdown
Member

No description provided.

Redis commands and connection checkouts had no upper bound, so during a
Valkey cluster failover requests to the vanished primary hung. The rate
limiter runs on every route, including the one used by Kubernetes
probes, which caused readiness failures and liveness kills.

Cap every Redis command and connection checkout at 2s, set pool
create/recycle timeouts, and set TCP_USER_TIMEOUT on the multiplexed
cluster client so dead nodes trigger a slot refresh. Add a /healthz
endpoint that touches no backing services, skips rate limiting and only
answers requests from loopback, private or link-local peers.
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@clrxbl

clrxbl commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio queue

@mergify

mergify Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

✅ Merged into main as 69541eb at 19:10 UTC

Less than a minute in the queue, less than a minute of it CI.

So far

  • ✅ Entered the queue Mon 2 Nov, 19:10 · rule default · triggered by @clrxbl with the @mergifyio queue command
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged 19:10 · 69541eb
2 merge conditions met
  • github-review-approved · required by GitHub branch protection
  • any of · required by GitHub branch protection:
    • check-success = Lint and Test
    • check-neutral = Lint and Test
    • check-skipped = Lint and Test

Times in UTC · dashboard · how the merge queue works

@mergify mergify Bot added the queued label Nov 2, 2026
@mergify
mergify Bot merged commit 69541eb into main Nov 2, 2026
12 checks passed
@mergify
mergify Bot deleted the michael/redis-timeout branch November 2, 2026 19:10
@mergify mergify Bot removed the queued label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants