Skip to content

fix: safari billing page truncation - #8199

Closed
jasonzli-DEV wants to merge 1 commit into
modrinth:mainfrom
jasonzli-DEV:fix/safari-billing-page-truncation
Closed

jasonzli-DEV wants to merge 1 commit into
modrinth:mainfrom
jasonzli-DEV:fix/safari-billing-page-truncation

Conversation

@jasonzli-DEV

Copy link
Copy Markdown

This PR fixes an issue where resizing the billing page in Safari would cause it to go off the screen.

This also closes #8178.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@Prospector

Copy link
Copy Markdown
Member

this is not how you solve a problem like this, pls don't contribute stuff unless you understand the problem

@Prospector Prospector closed this Nov 3, 2026
@jasonzli-DEV

Copy link
Copy Markdown
Author

this is not how you solve a problem like this, pls don't contribute stuff unless you understand the problem

I understand the problem and want to help.
If you want it done differently, just say so.
I don't know how you want it, and unless you say how you want it, there is no way for me to contribute.
There are a million different ways something can be done, and the right way and understanding the problem are all opinionated.

@Prospector

Copy link
Copy Markdown
Member

you just made the width some crazy magic number formula calculation

@jasonzli-DEV

Copy link
Copy Markdown
Author

you just made the width some crazy magic number formula calculation

Safari’s SVG sizing makes the logos take up too much width, so the billing cards expand beyond the viewport.

The magic number formula sets each logo’s width from its existing height and the aspect ratio defined by the viewBox to fix the issue.

I did say that there are a million ways to do something. If you want a different way, just say the word.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Billing Page expands to the right in Safari on macOS

2 participants