Repository navigation
Conversation
|
Note This changelog has been merged into the changelog for #8152 Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
[Medium impact] The changes are confined to the project-review workflow and its internal flag API client. The PR appears safe to merge, with a non-blocking issue in the flag preview’s rule link.
|
| <span class="min-w-0 break-words">{{ flag.name || flag.key }}</span> | ||
| </h3> | ||
| <ButtonLink | ||
| v-tooltip="'View flag rule'" |
There was a problem hiding this comment.
Hovering “View flag rule” inside a flag preview removes the card before the user can click the link. The card is already inside an interactive Tooltip, but this nested v-tooltip replaces the shared activeTooltip with plain text. Remove the nested tooltip here and keep the existing aria-label.
| v-tooltip="'View flag rule'" |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/frontend/src/components/project-review/flag-list/flag-card.vue
Line: 11
Comment:
**Flag preview link disappears**
Hovering “View flag rule” inside a flag preview removes the card before the user can click the link. The card is already inside an interactive `Tooltip`, but this nested `v-tooltip` replaces the shared `activeTooltip` with plain text. Remove the nested tooltip here and keep the existing `aria-label`.
```suggestion
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Frontend previewsLast deployed commit is d28b4db19ea4c15c00ca9e41fc5cf1cbc88574a0 Persistent
Latest commit
|
No description provided.