Skip to content

feat: surfacing flags in modview - #8240

Draft
tdgao wants to merge 2 commits into
boris/dev-1493-flag-rules-backendfrom
truman/surfacing-flags-in-modview
Draft

tdgao wants to merge 2 commits into
boris/dev-1493-flag-rules-backendfrom
truman/surfacing-flags-in-modview

Conversation

@tdgao

@tdgao tdgao commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Note

This changelog has been merged into the changelog for #8152

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@tdgao tdgao changed the title fea/surfacing flags in modview feat: surfacing flags in modview Nov 5, 2026
@tdgao
tdgao marked this pull request as draft November 5, 2026 22:55
@mergify

mergify Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The changes are confined to the project-review workflow and its internal flag API client.

The PR appears safe to merge, with a non-blocking issue in the flag preview’s rule link.

Summary

Adds a Flags tab, flag cards, panel badges, and flag previews to project review. It also adds getProjectFlags and expands ProjectFlag.

  • Project reviewers can browse flags in a new Flags tab.
  • Related flags appear beside the review panels they refer to.
  • The internal API client can request a project's flags.
  • The re-review count badge looks lighter while the flag editor keeps its highlighting.

Reviews (1) · Last reviewed commit: "pnpm prepr" · Reviewed by Greptile

<span class="min-w-0 break-words">{{ flag.name || flag.key }}</span>
</h3>
<ButtonLink
v-tooltip="'View flag rule'"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Flag preview link disappears

Hovering “View flag rule” inside a flag preview removes the card before the user can click the link. The card is already inside an interactive Tooltip, but this nested v-tooltip replaces the shared activeTooltip with plain text. Remove the nested tooltip here and keep the existing aria-label.

Suggested change
v-tooltip="'View flag rule'"
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/frontend/src/components/project-review/flag-list/flag-card.vue
Line: 11

Comment:
**Flag preview link disappears**

Hovering “View flag rule” inside a flag preview removes the card before the user can click the link. The card is already inside an interactive `Tooltip`, but this nested `v-tooltip` replaces the shared `activeTooltip` with plain text. Remove the nested tooltip here and keep the existing `aria-label`.

```suggestion

```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Frontend previews

Last deployed commit is d28b4db19ea4c15c00ca9e41fc5cf1cbc88574a0

Persistent

Environment URL
staging https://pr-8240.frontend-staging.rinth.dev
production https://pr-8240.frontend.rinth.dev
storybook https://pr-8240-storybook.modrinth.workers.dev

Latest commit

Environment URL
staging https://c13d8012.frontend-staging.rinth.dev
production https://fc834298.frontend.rinth.dev

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant