Error on leaked transaction handle

Treat a failed Arc::try_unwrap on the transaction handle as a transaction error instead of silently skipping rollback. database.rs now maps an unwrap failure to Error::transaction("transaction handle leaked outside the transaction scope") and still calls rollback when the unwrap succeeds. Added a test (sqlite_transaction_leak_on_error_returns_transaction_error) that leaks a transaction-scoped Database handle and asserts the new error is returned.

Author: mohamadzoh

src/database.rs

@@ -421,9 +421,12 @@ impl Database {
                 Ok(result)
             }
             Err(e) => {
-                if let Ok(txn) = Arc::try_unwrap(txn) {
-                    let _ = txn.rollback().await;
-                }
+                let txn = Arc::try_unwrap(txn).map_err(|_| {
+                    Error::transaction(
+                        "transaction handle leaked outside the transaction scope".to_string(),
+                    )
+                })?;
+                let _ = txn.rollback().await;
                 Err(e)
             }
         }

tests/sqlite_ci_smoke_test.rs

@@ -1,6 +1,13 @@
+use std::sync::{Mutex, OnceLock};
+
 use tideorm::prelude::*;
 use tideorm::{Database, TideConfig};
 
+fn leaked_transaction_db_slot() -> &'static Mutex<Option<Database>> {
+    static LEAKED_TRANSACTION_DB: OnceLock<Mutex<Option<Database>>> = OnceLock::new();
+    LEAKED_TRANSACTION_DB.get_or_init(|| Mutex::new(None))
+}
+
 #[derive(Model, PartialEq)]
 #[tideorm(table = "ci_users")]
 struct CiUser {
@@ -172,6 +179,49 @@ async fn sqlite_transaction_model_methods_use_transaction_connection() {
     assert_eq!(still_present.email, "baseline@example.com");
 }
 
+#[tokio::test]
+async fn sqlite_transaction_leak_on_error_returns_transaction_error() {
+    TideConfig::init()
+        .database_type(DatabaseType::SQLite)
+        .database("sqlite::memory:")
+        .max_connections(1)
+        .connect()
+        .await
+        .expect("failed to connect to SQLite");
+
+    leaked_transaction_db_slot()
+        .lock()
+        .expect("leaked transaction slot lock poisoned")
+        .take();
+
+    let err = CiUser::transaction(|_tx| {
+        Box::pin(async move {
+            let leaked_db = tideorm::database::__current_db()
+                .expect("transaction-scoped database should be available inside transaction");
+            *leaked_transaction_db_slot()
+                .lock()
+                .expect("leaked transaction slot lock poisoned") = Some(leaked_db);
+
+            Err::<(), _>(tideorm::Error::query(
+                "rollback with leaked transaction handle",
+            ))
+        })
+    })
+    .await
+    .expect_err("leaked transaction handle should surface as a transaction error");
+
+    assert!(
+        err.to_string()
+            .contains("transaction handle leaked outside the transaction scope"),
+        "unexpected error: {err}"
+    );
+
+    leaked_transaction_db_slot()
+        .lock()
+        .expect("leaked transaction slot lock poisoned")
+        .take();
+}
+
 #[tokio::test]
 async fn sqlite_query_with_and_find_with_work_without_global_db() {
     use tideorm::internal::{ActiveModelTrait, ConnectionTrait, InternalModel};