feat: range-aware inverted index - #476
Open
Tom Hepworth (ThomasHepworth) wants to merge 2 commits into
Open
Conversation
…tandardise numeric ranges in regex
🚨 Benchmark Check Required Before MergeBefore merging this PR, make sure that you run the following check to test for performance regression: bash ./shell/compare_commits.sh \
-b main \
-c 3c53663600bc51a899f8073b986ef064fd3b4bda \
-d rhondda,aberdeenshire,hackney,mid_sussexThis comment updates automatically whenever a new commit is pushed to the PR. Note If you have changed the cleaning, you will need to rerun cleaning prep in order to test these changes successfully. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Operational Change
The cleaning pipeline now converts numeric
TOranges into dash ranges:55 TO 57becomes55-57The inverted-index pipeline then:
numeric_tokenscontaining-as a cheap candidate filter.20.55-57 OLD) ->55 OLD,56 OLD, and57 OLD.Additional Canonical Records
No additional canonical address rows are created. The canonical row count remains unchanged.
The persisted inverted index changed as follows:
For the verified blocking-miss sample:
0/143rows.10/143rows.3/80distinct messy records.Accuracy Results
The change was tested on the pooled councils dataset:
The controlled comparison used the same matching stages and compared the old canonical index with the range-aware canonical index: