feat(reasoning): add max effort level - #1253
Open
GTanger wants to merge 3 commits into
Open
Conversation
Contributor
Greptile SummaryAdds a shared maximum reasoning-effort level and carries it from configuration and model suffix parsing through provider-specific mappings and the browser selector.
Confidence Score: 4/5The PR appears safe to merge, with the non-blocking requirement to document the new user-facing configuration value and expose it in the configuration template. The enum, suffix, provider mappings, and UI flow consistently handle Max, while the remaining issue is stale configuration discovery documentation rather than a runtime defect. Files Needing Attention: crates/config/src/schema.rs, docs/src/configuration-reference.md, crates/config/src/template.rs
|
| Filename | Overview |
|---|---|
| crates/config/src/schema.rs | Adds the Max enum variant and its parsing, serialization, ordering, and display label, but the user-facing config documentation remains stale. |
| crates/providers/src/model_id.rs | Adds complete @reasoning-max suffix parsing and raw-ID stripping coverage. |
| crates/providers/src/openai/provider/core.rs | Maps Max according to existing provider policies, including clamping OpenAI Chat Completions to high. |
| crates/providers/src/openai_codex.rs | Forwards Max as the literal reasoning.effort = "max" Responses API value and tests the wire representation. |
| crates/providers/src/anthropic.rs | Clamps Max to the existing 65,536-token upper thinking budget. |
| crates/web/ui/src/reasoning-toggle.ts | Adds Max to the selector and maps it to the new localized label. |
| crates/web/ui/e2e/specs/reasoning-toggle.spec.js | Extends browser coverage for option rendering and the @reasoning-max chat payload. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
UI[Reasoning selector: Max] --> ID[Model ID @reasoning-max]
Config[reasoning_effort = max] --> Effort[ReasoningEffort::Max]
ID --> Parser[Suffix parser]
Parser --> Effort
Effort --> Route{Provider adapter}
Route --> Codex[OpenAI Codex: max]
Route --> OpenAI[OpenAI Chat: high]
Route --> Anthropic[Anthropic: 65536 token budget]
Route --> DeepSeek[DeepSeek: max]
Route --> Kimi[Kimi: max]
Reviews (1): Last reviewed commit: "feat(reasoning): add max effort" | Re-trigger Greptile
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxto the sharedReasoningEffortschema and@reasoning-maxmodel suffix parsingmaxunchanged through the OpenAI Codex Responses API while clamping providers that do not expose a distinct maximum levelValidation
cargo test -p moltis-config reasoning_effort(3 passed)cargo test -p moltis-config write_default_config_writes_template_to_requested_path(passed)cargo test -p moltis-providers reasoning_effort(9 passed)npm run typecheckreasoning-toggle.spec.js(7 passed in Chromium)cargo build --bin moltisscripts/check-changelog-guard.sh origin/main HEADManual QA
A local Moltis build was exercised through the web UI with
openai-codex::gpt-5.6-sol@reasoning-max. The request reached the provider asreasoning.effort = "max"and completed successfully.The full AI-assisted session is not attached because it contains private local authentication, deployment details, and unrelated workspace context. This PR includes the relevant implementation decisions and redacted validation results.