CDRIVER-6300 CSFLE/QE Support for HTTP Proxies - #2318
Open
mdb-ad wants to merge 29 commits into
Open
Conversation
eramongodb
requested changes
Jun 17, 2026
eramongodb
requested changes
Jun 26, 2026
Comment on lines
+245
to
+247
| if (!opts) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
Calling a setter with opts == NULL is almost certainly programmer error: recommend using BSON_ASSERT_PARAM instead of an if (!opts) (better consistency with *_set_kms_credential_provider_callback()).
Collaborator
There was a problem hiding this comment.
Unresolving since this is not-yet addressed.
Aside: @mdb-ad I'd recommend using the 👍 react, rather than resolving, to acknowledge a comment when a reply isn't needed. As a reviewer, I generally prefer to resolve comments on re-review, as that cues me to remember what motivated the new changes.
Co-authored-by: Ezra Chung <88335979+eramongodb@users.noreply.github.com>
kevinAlbs
reviewed
Jul 15, 2026
Co-authored-by: Kevin Albertson <kevin.eric.albertson@gmail.com>
Co-authored-by: Kevin Albertson <kevin.eric.albertson@gmail.com>
Co-authored-by: Kevin Albertson <kevin.eric.albertson@gmail.com>
kevinAlbs
reviewed
Aug 17, 2026
Comment on lines
+11
to
+15
| typedef mongoc_stream_t *(*mongoc_kms_connect_callback_fn_t) (const char *host, | ||
| uint16_t port, | ||
| int32_t connecttimeoutms, | ||
| void *user_data, | ||
| bson_error_t *error); |
Collaborator
There was a problem hiding this comment.
Suggest passing arguments through a new type similar to mongoc_oidc_callback_params_t. Though it adds more symbols, it more easily permits future extension by adding getters to the type.
Co-authored-by: Kevin Albertson <kevin.eric.albertson@gmail.com>
kevinAlbs
self-requested a review
August 31, 2026 17:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing with the proxy server (from drivers-evergreen-tools): https://spruce.corp.mongodb.com/version/6a3b6a38da38fa0007d62c53