Fix: Zoom controls for paths/nodes not working in Stream mode

Author: tferr

src/main/java/sc/fiji/snt/CurationManager.java

@@ -1063,7 +1063,9 @@ private JPopupMenu getFilterVisibilityMenu() {
     private JPopupMenu getToolsMenu() {
         final JPopupMenu popup = new JPopupMenu();
         GuiUtils.addSeparator(popup, "Navigation:");
-        popup.add(visitingZoom.zoomControls("Visiting Zoom Level", "issues"));
+        final JMenu zMenu = visitingZoom.zoomControls("Visiting Zoom Level", "issues");
+        zMenu.setEnabled(sntui != null && !sntui.isStreamMode());
+        popup.add(zMenu);
         GuiUtils.addSeparator(popup, "Path Tagging:");
         final JMenuItem colorMenuItem = new JMenuItem("Color Affected Paths by Issue Severity");
         colorMenuItem.setIcon(IconFactory.menuIcon(IconFactory.GLYPH.DANGER));

src/main/java/sc/fiji/snt/PathManagerUI.java

@@ -43,6 +43,7 @@
 import sc.fiji.snt.plugin.*;
 import sc.fiji.snt.tracing.auto.SomaUtils;
 import sc.fiji.snt.util.*;
+import sc.fiji.snt.viewer.AbstractBigViewer;
 
 import javax.swing.Timer;
 import javax.swing.*;
@@ -5893,6 +5894,7 @@ private JButton zoomToNodeButton() {
                     });
             menu.addSeparator();
             final JMenu zMenu = visitingZoom.zoomControls("Zoom to Node", "nodes");
+            zMenu.setEnabled(plugin.getUI() != null && !plugin.getUI().isStreamMode());
             zMenu.setText("Visiting Zoom Level");
             zMenu.setToolTipText("The magnification to be used when zooming into a node");
             menu.add(zMenu);
@@ -6075,7 +6077,7 @@ private boolean canExecuteZoomOperation(final Collection<Path> paths) {
                 guiUtils.error("No path(s) selected.");
                 return false;
             }
-            if (plugin.getImagePlus() == null) {
+            if (plugin.getImagePlus() == null && (plugin.getUI() == null || plugin.getUI().getActiveBigViewer() == null)) {
                 guiUtils.error("Image is not available.");
                 return false;
             }
@@ -6102,10 +6104,13 @@ private void zoomToNode(final Path.PathNode node, GuiUtils.VisitingZoom visiting
 
         private void zoomToBoundingBox(final Collection<Path> paths) {
             if (!canExecuteZoomOperation(paths)) return;
-            final double prevMag = plugin.getImagePlus().getCanvas().getMagnification();
-            final double zoom = ImpUtils.zoomTo(plugin.getImagePlus(), paths);
-            plugin.setCanvasLabelAllPanes((zoom == prevMag) ? "Selected paths already in view" :
-                    String.format("Zoomed to selected paths: (%.0f%%)", zoom * 100));
+            double zoom = GuiUtils.VisitingZoom.DEFAULT_PERCENT / 100d;
+            if (plugin.getImagePlus() != null) {
+                final double prevMag = plugin.getImagePlus().getCanvas().getMagnification();
+                zoom = ImpUtils.zoomTo(plugin.getImagePlus(), paths);
+                plugin.setCanvasLabelAllPanes((zoom == prevMag) ? "Selected paths already in view" :
+                        String.format("Zoomed to selected paths: (%.0f%%)", zoom * 100));
+            }
             zoomOtherPanesAsNeeded(paths, zoom);
             final Timer timer = new Timer(600, ae -> plugin.setCanvasLabelAllPanes(null));
             timer.setRepeats(false);
@@ -6122,6 +6127,20 @@ private void zoomOtherPanesAsNeeded(final Collection<Path> paths, final double m
                 if (xzImp != null)
                     ImpUtils.zoomTo(xzImp, magnification, paths, RoiConverter.XZ_PLANE);
             }
+            flyActiveBigViewerToBoundingBoxAsNeeded(paths);
+        }
+
+        /**
+         * Flies the active Bdv/Bvv viewer (if any) to the bounding box of {@code paths}, via
+         * {@link AbstractBigViewer#flyTo(sc.fiji.snt.util.BoundingBox)}
+         *
+         * @param paths the paths whose bounding box the viewer should frame
+         */
+        private void flyActiveBigViewerToBoundingBoxAsNeeded(final Collection<Path> paths) {
+            final AbstractBigViewer viewer = plugin.getUI().getActiveBigViewer();
+            if (viewer != null) {
+                viewer.flyTo(new Tree(new ArrayList<>(paths)).getBoundingBox());
+            }
         }
 
         void restoreFullModelState() {

src/main/java/sc/fiji/snt/viewer/AbstractBigViewer.java

@@ -31,6 +31,7 @@
 import sc.fiji.snt.gui.GuiUtils;
 import sc.fiji.snt.gui.IconFactory;
 import sc.fiji.snt.tracing.SearchInterface;
+import sc.fiji.snt.util.BoundingBox;
 import sc.fiji.snt.util.PointInImage;
 import sc.fiji.snt.util.SNTColor;
 import sc.fiji.snt.util.SNTPoint;
@@ -375,6 +376,50 @@ protected static void addToCardPanelBottom(final bdv.ui.CardPanel cardPanel, fin
      */
     public abstract void setCurrentTimepoint(int timepoint);
 
+    /**
+     * Animates the camera to frame the given world-coordinate bounding box: an isotropic scale is
+     * computed so the box's width/height fit the viewport, and the transform is translated to
+     * center the box's centroid on screen. Any existing rotation is dropped.
+     * <p>
+     * A degenerate box (zero width/height - e.g. a single-node selection, whose origin and
+     * originOpposite are the same point) cannot be "fit" (there is nothing to scale to), so this
+     * recenters on the centroid at the viewer's <em>current</em> zoom level instead.
+     *
+     * @param box the world-coordinate bounding box to frame; a no-op if {@code null}, its corners
+     *            are not real (e.g. an empty/uncomputed box), or the viewport has not yet been realized
+     * @return {@code true} if the transform was computed and applied; {@code false} otherwise
+     */
+    public boolean flyTo(final BoundingBox box) {
+        if (box == null || !box.origin().isReal() || !box.originOpposite().isReal()) return false;
+        final int cw = getViewerWidth(), ch = getViewerHeight();
+        if (cw <= 0 || ch <= 0) return false;
+        final double physW = box.width(), physH = box.height();
+        final double scale;
+        if (physW > 0 && physH > 0) {
+            scale = Math.min(cw / physW, ch / physH);
+        } else {
+            // Degenerate (point-like) box: can't compute a fit scale, so keep the current zoom
+            // and just recenter. Column norm rather than a raw matrix entry so this is correct
+            // even if the current transform happens to carry rotation.
+            final AffineTransform3D current = getViewerTransform();
+            final double currentScale = Math.sqrt(
+                    current.get(0, 0) * current.get(0, 0) +
+                    current.get(1, 0) * current.get(1, 0) +
+                    current.get(2, 0) * current.get(2, 0));
+            scale = (currentScale > 0 && Double.isFinite(currentScale)) ? currentScale : 1;
+        }
+        final SNTPoint centroid = box.getCentroid();
+        final AffineTransform3D target = new AffineTransform3D();
+        target.set(scale, 0, 0);
+        target.set(scale, 1, 1);
+        target.set(scale, 2, 2);
+        target.set(cw / 2.0 - scale * centroid.getX(), 0, 3);
+        target.set(ch / 2.0 - scale * centroid.getY(), 1, 3);
+        target.set(-scale * centroid.getZ(), 2, 3);
+        setViewerTransform(target, 300);
+        return true;
+    }
+
     /**
      * Creates and returns a new {@link sc.fiji.snt.BookmarkManager} for this viewer.
      * Called exactly once (lazily) by {@link #getMarkerManager()}.
@@ -668,8 +713,6 @@ public void actionPerformed(final ActionEvent e) {
                         showViewerMessage("No source selected");
                         return;
                     }
-                    final int cw = getViewerWidth(), ch = getViewerHeight();
-                    if (cw <= 0 || ch <= 0) return;
                     final AffineTransform3D srcToWorld = new AffineTransform3D();
                     src.getSpimSource().getSourceTransform(0, 0, srcToWorld);
                     final net.imglib2.RandomAccessibleInterval<?> rai = src.getSpimSource().getSource(0, 0);
@@ -695,17 +738,10 @@ public void actionPerformed(final ActionEvent e) {
                         minZ = Math.min(minZ, world[2]);
                         maxZ = Math.max(maxZ, world[2]);
                     }
-                    final double physW = maxX - minX, physH = maxY - minY, physZ = maxZ - minZ;
-                    if (physW <= 0 || physH <= 0) return;
-                    final double scale = Math.min(cw / physW, ch / physH);
-                    final AffineTransform3D target = new AffineTransform3D();
-                    target.set(scale, 0, 0);
-                    target.set(scale, 1, 1);
-                    target.set(scale, 2, 2);
-                    target.set(cw / 2.0 - scale * (minX + physW / 2.0), 0, 3);
-                    target.set(ch / 2.0 - scale * (minY + physH / 2.0), 1, 3);
-                    target.set(-scale * (minZ + physZ / 2.0), 2, 3);
-                    setViewerTransform(target, 300);
+                    final BoundingBox box = new BoundingBox();
+                    box.setOrigin(new PointInImage(minX, minY, minZ));
+                    box.setOriginOpposite(new PointInImage(maxX, maxY, maxZ));
+                    flyTo(box); // silently no-ops if the viewport isn't realized yet or the box is degenerate
                 }
             };
         }