Fix Engine atexit cleanup lifetime - #3943
Open
galitheia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Composer currently registers the same static
_closecallback for everyEngine and passes each Engine's state and logger into
atexit. Manuallyclosing an Engine does not unregister that entry, retaining training objects
and allowing cleanup to run again during interpreter shutdown.
Additionally,
Engine.__del__()unregisters the shared callback globally,which can remove handlers belonging to other live Engines. This prevents
bounded repeated in-process Trainer lifetimes.
This change gives every Engine a unique weak atexit callback, makes close()
idempotent, and unregisters only the callback owned by that Engine.
Summary
interpreter-exit cleanup.
Testing