Do not evict local-only shards under cache_limit - #989
Open
gyanu2507 wants to merge 1 commit into
Open
Conversation
Streams with remote=None have no copy to restore from, so evicting them under cache_limit is data loss rather than cache reclaim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a stream is created with
remote=None, the files underlocalare the dataset, not a cache. Mixing that with a remote-backed stream and a finitecache_limitlet_evict_coldest_sharddelete those files, and there is nothing to download them back from.Eviction now skips shards whose stream has no remote. If the only local shards are local-only, it raises instead of deleting them.
Fixes #988