Fix saving email notification settings with an empty From address - #3408
Merged
Conversation
The backend input_sanity_check() throws a ValueError when the From address field in the email notification settings is empty, preventing the settings from being saved. The sanity-check regex requires at least one character. The frontend does not require this field to be set. The UI help mark says: “the first destination email address will be used if left blank.” We now skip the sanity check for an empty value. I guess we could also edit the regex itself if preferred, but it is shared across multiple input fields.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an inconsistency between the UI and backend validation by allowing the email notification From field (email_notifications_from) to be empty without failing backend input sanity checks, so settings can be saved when the UI leaves it blank.
Changes:
- Skip
input_sanity_check()foremail_notifications_fromwhen the UI value is an empty string. - Reuse a computed
email_fromvalue when formatting thesendmailcommand line for theon_event_starthook.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend
input_sanity_check()throws a error:when the From address field in the email notification settings is empty, preventing the settings from being saved. The sanity-check regex requires at least one character. The frontend does not require this field to be set. The UI help mark says:
motioneye/motioneye/locale/en/LC_MESSAGES/motioneye.po
Line 1358 in da7e73b
email_notifications_fromis empty. I guess we could also edit the regex itself if preferred, but it is shared across multiple input fields.