Skip to content

Commit de05fa5

Browse files
committed
changelog: correct the rule and test counts
Both were consumer-facing and stale: 11 rules -> 15 (T0-T14), 44 tests -> 48. Also notes that only 12 of the 15 are trace-matching entries in RULES, since T10/T11/T12 are status-based checks in triage() and anyone counting RULES would otherwise think three were missing.
1 parent 19c8aab commit de05fa5

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

‎tae-conversion/CHANGELOG.md‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ verdict semantics, changed flags. `git log` has the rest.
1414
- `efftriage.py` — reads a batch's `run-report.txt` + `status.json` and names the likely cause of a failure
1515
with its HARNESS-GOTCHAS id and the fix. Read-only, so it is safe to run on every failure. Scans the FIRST
1616
attempt only, because a failed attempt leaves state behind and later attempts die somewhere later and more
17-
confusingly. 11 rules (T0–T10), hardened against 8 labelled failures from the search batch. (MTE-5827)
17+
confusingly. 15 rules (T0–T14): 12 match the trace and live in `RULES`, while **T10 (crash), T11 (skip) and T12
18+
(compile failure) are status-based checks** in `triage()` — so counting `RULES` alone gives 12, not 15.
19+
Hardened against labelled failures from the search batch and then against batch 2's own, which is where
20+
T11–T14 came from. (MTE-5827)
1821
- `effdoctor.py` slice 1 — read-only preflight, and specifically the **toolchain map**. The eff* tools exist
1922
once but are reachable from two checkouts, and `effwatch.sh` derives its queue from `dirname $0`, which does
2023
not resolve symlinks: the queue it watches depends on the path it was launched from, while the tools are
@@ -25,7 +28,7 @@ verdict semantics, changed flags. `git log` has the rest.
2528
resolving it against the caller's cwd yields a directory that never existed. A computed queue that is not on
2629
disk is reported as a failure, and an unreadable cwd as "undetermined": naming the wrong queue confidently is
2730
worse than declining to name one. (MTE-5766)
28-
- **Unit tests** (`tae-conversion/tests/`, 44 of them) and a CI job, where previously the toolchain had none.
31+
- **Unit tests** (`tae-conversion/tests/`, 48 of them) and a CI job, where previously the toolchain had none.
2932
Run them with `python -m unittest discover -s tae-conversion/tests -p '*tests.py'`; no device, emulator,
3033
Firefox checkout or network needed, since `ps`/`lsof`/`adb`/`git` are stubbed. The efftriage rule tests run
3134
against **real labelled conversion runs** checked in under `tests/fixtures/corpus` with a `labels.json`

0 commit comments

Comments
 (0)