Conversation
5 tasks
… `common` drawer Two structural changes, neither of which changes behaviour. `pop_request_hash_from_url` built a `RequestHash` but lived in `mars::ad_response`, a module that otherwise holds MARS wire types. It is now `RequestHash::pop_from_url` in `http_cache::request_hash`, next to the type it constructs and the rest of its API. Its test moved with it and is named for what it asserts. The only call sites are still commented out pending the Nimbus cache-invalidation work, so the `allow(dead_code)` and its TODO move across unchanged. `common` held `bytesize` and `clock` — two unrelated, self-contained modules filed under a name that says nothing about either. Both are now top-level `crate::bytesize` and `crate::clock`, and `common.rs` is gone. Imports updated at the 14 call sites; no code inside either module changed. `fmt`, `clippy --all-targets -D warnings` and the 101 unit tests are green.
Almaju
force-pushed
the
ads-client-modeling-fixes
branch
from
September 22, 2026 00:17
261d5df to
b2bce14
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small refactors in
ads-client, no behaviour change.pop_request_hash_from_urlbuilt aRequestHashbut lived inmars::ad_response, which otherwise holds MARS wire types. It's nowRequestHash::pop_from_urlover inhttp_cache::request_hash, next to the type it builds, and its test moved with it. Both call sites are still commented out pending the Nimbus cache invalidation work, so theallow(dead_code)came across unchanged.commonheldbytesizeandclock: two unrelated modules under a name that says nothing about either. They're nowcrate::bytesizeandcrate::clock. Imports updated at 14 call sites, nothing inside either module touched.Independent of #7612, doesn't depend on it.
Pull Request checklist
crate::common::{bytesize, clock}becomescrate::{bytesize, clock}, but consumers use the uniffi API.fmtandclippy --all-targets -- -D warningsclean, 101 unit tests pass.