CMake: link libm after libpng for static builds - #457
Open
skal65535 wants to merge 1 commit into
Open
Conversation
-lm is added before ${PNG_LIBRARY}, so libpng.a is scanned once libm is
already past and static builds fail:
libpng.a(png.c.o): undefined reference to `floor'
Link m again after PNG/ZLIB for cjpeg-static and djpeg-static.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-DBUILD_SHARED_LIBS=OFFfails to linkcjpeg-static/djpeg-static:mis linked before${PNG_LIBRARY}, solibpng.ais scanned once libm isalready past. Shared builds are unaffected —
sharedlib/findslibpng.sobefore the static suffix override.
Link
magain after PNG/ZLIB.Verified on Ubuntu 26.04 / gcc 15.2: static build links, and PNG input works
(
cjpeg-static in.png).