Skip to content

Commit 29e96bd

Browse files
committed
fix(transport/benches): use separate group name
1 parent c84a960 commit 29e96bd

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

‎.github/workflows/bench.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,7 @@ jobs:
176176
echo
177177
sed -E -e 's/^ //gi' \
178178
-e '/cset:.*last message/d' \
179+
-e '/^Criterion.rs ERROR: Error in Gnuplot:/d' \
179180
-e 's/((change|time|thrpt):[^%]*% )([^%]*%)(.*)/\1<b>\3<\/b>\4/gi' results.txt |\
180181
perl -p -0777 -e 's/(.*?)\n(.*?)(((No change|Change within|Performance has).*?)(\nFound .*?)?)?\n\n/<details><summary>$1: $4<\/summary><pre>\n$2$6<\/pre><\/details>\n/gs' |\
181182
sed -E -e 's/(Performance has regressed.)/:broken_heart: <b>\1<\/b>/gi' \

‎neqo-transport/benches/transfer.rs‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,10 @@ fn benchmark_transfer(c: &mut Criterion, label: &str, seed: Option<impl AsRef<st
5959

6060
// Benchmark with wallclock time, i.e. measure the compute efficiency.
6161
{
62-
let mut group = c.benchmark_group(format!("transfer/pacing-{pacing}/{label}"));
62+
let mut group =
63+
c.benchmark_group(format!("transfer/pacing-{pacing}/{label}/wallclock-time"));
6364
group.noise_threshold(0.03);
64-
group.bench_function("wallclock-time", |b| {
65+
group.bench_function("run", |b| {
6566
b.iter_batched(
6667
setup,
6768
|s| {
@@ -78,9 +79,10 @@ fn benchmark_transfer(c: &mut Criterion, label: &str, seed: Option<impl AsRef<st
7879
// Note: Given that this is using simulated time, we can measure actual
7980
// throughput.
8081
{
81-
let mut group = c.benchmark_group(format!("transfer/pacing-{pacing}/{label}"));
82+
let mut group =
83+
c.benchmark_group(format!("transfer/pacing-{pacing}/{label}/simulated-time"));
8284
group.throughput(criterion::Throughput::Bytes(TRANSFER_AMOUNT as u64));
83-
group.bench_function("simulated-time", |b| {
85+
group.bench_function("run", |b| {
8486
b.iter_custom(|iters| {
8587
let mut d_sum = Duration::ZERO;
8688
for _i in 0..iters {

0 commit comments

Comments
 (0)