Repository navigation
fix(transport/benches): use separate group name - #2934
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2934 +/- ##
==========================================
- Coverage 95.48% 93.10% -2.38%
==========================================
Files 120 120
Lines 34958 34958
Branches 34958 34958
==========================================
- Hits 33380 32548 -832
- Misses 1538 1560 +22
- Partials 40 850 +810
|
mxinden
force-pushed
the
criterion-panic
branch
from
September 3, 2025 11:08
58fa021 to
9767503
Compare
mxinden
force-pushed
the
criterion-panic
branch
from
September 3, 2025 13:16
9767503 to
820b658
Compare
mxinden
force-pushed
the
criterion-panic
branch
3 times, most recently
from
September 4, 2025 15:06
b84db21 to
9dca9a8
Compare
mxinden
changed the title
mxinden
force-pushed
the
criterion-panic
branch
3 times, most recently
from
September 5, 2025 07:11
3577e37 to
29e96bd
Compare
mxinden
force-pushed
the
criterion-panic
branch
from
September 5, 2025 11:13
ad18058 to
5b70e64
Compare
Contributor
Client/server transfer resultsPerformance differences relative to 12c7d94. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
Contributor
Benchmark resultsPerformance differences relative to 12c7d94. 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [207.38 ms 207.78 ms 208.33 ms]
thrpt: [480.00 MiB/s 481.27 MiB/s 482.21 MiB/s]
change:
time: [−0.5864% −0.2858% +0.0123%] (p = 0.07 > 0.05)
thrpt: [−0.0123% +0.2866% +0.5898%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [298.99 ms 300.45 ms 301.91 ms]
thrpt: [33.122 Kelem/s 33.283 Kelem/s 33.446 Kelem/s]
change:
time: [−0.1398% +0.5795% +1.3175%] (p = 0.11 > 0.05)
thrpt: [−1.3003% −0.5762% +0.1400%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [28.354 ms 28.422 ms 28.503 ms]
thrpt: [35.084 B/s 35.184 B/s 35.268 B/s]
change:
time: [−0.4336% −0.0548% +0.2974%] (p = 0.79 > 0.05)
thrpt: [−0.2966% +0.0548% +0.4355%]
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed. time: [213.49 ms 213.77 ms 214.10 ms]
thrpt: [467.07 MiB/s 467.78 MiB/s 468.40 MiB/s]
change:
time: [+1.4427% +1.6312% +1.8419%] (p = 0.00 < 0.05)
thrpt: [−1.8086% −1.6050% −1.4221%]
decode 4096 bytes, mask ff: No change in performance detected. time: [11.809 µs 11.849 µs 11.895 µs]
change: [−0.4131% +0.0250% +0.4175%] (p = 0.92 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0230 ms 3.0409 ms 3.0676 ms]
change: [−0.8563% +0.0238% +0.9096%] (p = 0.96 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.964 µs 20.026 µs 20.097 µs]
change: [−0.3508% +0.2337% +0.9581%] (p = 0.47 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.0458 ms 5.0571 ms 5.0702 ms]
change: [−0.5509% −0.1274% +0.2427%] (p = 0.54 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [8.2547 µs 8.2804 µs 8.3131 µs]
change: [−0.5551% −0.0654% +0.4163%] (p = 0.81 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.5867 ms 1.5926 ms 1.5995 ms]
change: [−0.7923% −0.1648% +0.4241%] (p = 0.61 > 0.05)
1-streams/each-1000-bytes/wallclock-time: No change in performance detected. time: [611.28 µs 613.41 µs 615.79 µs]
change: [−1.4075% −0.6685% −0.0562%] (p = 0.06 > 0.05)
1000-streams/each-1-bytes/wallclock-time: No change in performance detected. time: [14.688 ms 14.722 ms 14.757 ms]
change: [−0.1460% +0.1580% +0.4655%] (p = 0.32 > 0.05)
1000-streams/each-1000-bytes/wallclock-time: No change in performance detected. 1000-streams/each-1000-bytes/simulated-time time: [18.683 s 18.867 s 19.051 s] thrpt: [51.261 KiB/s 51.760 KiB/s 52.271 KiB/s] change: time: [−0.6936% +0.6691% +2.0561%] (p = 0.34 > 0.05) thrpt: [−2.0146% −0.6647% +0.6985%] No change in performance detected. time: [56.180 ms 56.412 ms 56.643 ms]
change: [−0.5238% −0.0085% +0.5263%] (p = 0.97 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [88.465 ns 89.141 ns 89.989 ns]
change: [+0.0587% +1.1211% +2.6070%] (p = 0.08 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [106.25 ns 106.76 ns 107.36 ns]
change: [−1.0875% −0.0369% +1.1145%] (p = 0.95 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [105.57 ns 105.83 ns 106.19 ns]
change: [−0.4125% +0.1434% +0.7157%] (p = 0.64 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [88.838 ns 89.069 ns 89.424 ns]
change: [−1.4416% −0.1826% +0.9836%] (p = 0.78 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [107.29 ms 107.47 ms 107.74 ms]
change: [+0.0598% +0.2396% +0.5278%] (p = 0.02 < 0.05)
sent::Packets::take_ranges: No change in performance detected. time: [4.7380 µs 4.8517 µs 4.9558 µs]
change: [−2.7074% +0.7345% +4.2095%] (p = 0.67 > 0.05)
transfer/pacing-false/varying-seeds/wallclock-time/run:time: [26.241 ms 26.286 ms 26.331 ms] transfer/pacing-false/varying-seeds/simulated-time/run: time: [25.117 s 25.149 s 25.181 s]
thrpt: [162.67 KiB/s 162.87 KiB/s 163.08 KiB/s]transfer/pacing-true/varying-seeds/wallclock-time/run:time: [26.535 ms 26.587 ms 26.638 ms] Found 1 outliers among 100 measurements (1.00%) 1 (1.00%) high mild transfer/pacing-true/varying-seeds/simulated-time/run: time: [24.960 s 25.001 s 25.043 s]
thrpt: [163.56 KiB/s 163.83 KiB/s 164.11 KiB/s]
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mildtransfer/pacing-false/same-seed/wallclock-time/run:time: [25.639 ms 25.668 ms 25.701 ms] Found 1 outliers among 100 measurements (1.00%) 1 (1.00%) high severe transfer/pacing-false/same-seed/simulated-time/run: time: [25.152 s 25.152 s 25.152 s]
thrpt: [162.85 KiB/s 162.85 KiB/s 162.85 KiB/s]::::transfer/pacing-true/same-seed/wallclock-time/run:time: [27.312 ms 27.331 ms 27.351 ms] Found 3 outliers among 100 measurements (3.00%) 1 (1.00%) low mild 2 (2.00%) high mild transfer/pacing-true/same-seed/simulated-time/run: time: [25.588 s 25.588 s 25.588 s]
thrpt: [160.07 KiB/s 160.07 KiB/s 160.07 KiB/s]::::Download data for |
mxinden
marked this pull request as ready for review
September 5, 2025 14:32
mxinden
requested review from
KershawChang,
larseggert and
martinthomson
as code owners
September 5, 2025 14:32
Member
Author
|
Ready for review. @larseggert I can fix the empty sections in the benchmark comment in a follow-up. No need to block all of you. |
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to c84a960. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
larseggert
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Criterion needs each group name to be unique. Otherwise it will panic as it does in #2933.
Introduced in #2909. Though given that no
mainbaseline was available, first only surfaced in #2897.Fixes #2933.
Blocked on #2943.