Skip to content

Dev: Improve preview.js. - #34407

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev3
Aug 31, 2026
Merged

Dev: Improve preview.js.#34407
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev3

Conversation

@Mugen87

@Mugen87 Mugen87 commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Related issue: -

Description

I've recently updated node.js on my system and see below log now when running npm run preview:

(node:11600) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.

To fix this warning, preview.js is rewritten to avoid using npx and shell: true. The script now directly resolve rollup's bin and runs it.

I've tested this with macOS but it should work under Windows as well.

@Mugen87 Mugen87 added this to the r186 milestone Aug 31, 2026
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
Core 389.13
102.11
389.13
102.11
+0 B
+0 B
WebGL 372.46
87.93
372.46
87.93
+0 B
+0 B
WebGPU 704.94
194.28
704.94
194.28
+0 B
+0 B
WebGPU Nodes 702.93
193.96
702.93
193.96
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 515.87
124.88
515.87
124.88
+0 B
+0 B
WebGPU 762.71
204.8
762.71
204.8
+0 B
+0 B
WebGPU Nodes 711.37
192.07
711.37
192.07
+0 B
+0 B

@Mugen87
Mugen87 merged commit a0af03b into mrdoob:dev Aug 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant