Tests: Remove empty QUnit.module scaffolding - #34409
Merged
Merged
Conversation
28 files under test/unit/src contained only nested QUnit.module scaffolding with no QUnit.test calls and the import line commented out. They were still registered in three.source.unit.js and ran as part of npm run test-unit, so the module tree read as broader coverage than actually exists. Removes the 28 empty stub files and their imports (mrdoob#34371). npm run test-unit: 1315 pass, 1 todo (pre-existing), 0 fail — same as before this change, since no QUnit.test calls existed in these files to begin with. npm run lint-test is unaffected by this diff.
Mugen87
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #34371
Description
28 files under
test/unit/srccontained only nestedQUnit.modulescaffolding with noQUnit.testcalls inside them, and the import line at the top left commented out. They were still registered intest/unit/three.source.unit.jsand ran as part ofnpm run test-unit, so the module tree in the test report reads as broader coverage than actually exists.A previous PR filled in real tests for 17 of these, but was closed by its own author to get more familiar with the test framework first. @mrdoob's follow-up on the issue suggested the simpler alternative — removing them — so this PR does that for all 28 (both the group tractable without a live GL context and the group that would need one), rather than leave a partially-covered set of stubs behind.
Removed, with their corresponding
importline inthree.source.unit.js:animation/AnimationUtils,animation/PropertyMixeraudio/AudioAnalyserextras/Earcut,extras/ImageUtils,extras/PMREMGenerator,extras/ShapeUtils,extras/core/Interpolationsrenderers/WebGLRendererrenderers/webgl/WebGLAttributes,WebGLBackground,WebGLBufferRenderer,WebGLCapabilities,WebGLClipping,WebGLGeometries,WebGLIndexedBufferRenderer,WebGLLights,WebGLMorphtargets,WebGLObjects,WebGLProgram,WebGLPrograms,WebGLProperties,WebGLShader,WebGLShadowMap,WebGLState,WebGLTextures,WebGLUniforms,WebGLUtilsNo source files are touched — this is test scaffolding only.
Verification
Same pass/todo/fail counts as before this change (the single
todois the pre-existingMesh.raycastone) — expected, since none of the removed files had anyQUnit.testcalls to lose.$ npm run lint-testClean on every file in this diff (
lint-testreports pre-existing errors in a few unrelated addon test files that this PR doesn't touch).