Repository navigation
test: cross-process cache invalidation and lifetime coverage (DEVRES-4325) - #109
Merged
Merged
Conversation
Owner
Author
|
CI at 7f2ec34: lint/typecheck, unit tests and all three Redis/Valkey integration jobs pass. All six browser E2E jobs fail before tests run, during browser installation: |
- Stamp build-output fixtures relative to the workers' fixed clock, so the resurrection cases stop depending on today's date. - Split the known page hard-expiry bug: setup and positive checks run as an ordinary test; test.fails asserts only the stored Redis TTL against render start, instead of a timed read that a slow run could flip. - Remove the compiled worker directory when tsc fails. - Renumber the duplicate DEC-16 (#106's entry is DEC-17, the runner pin DEC-18). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds isolated Node-process tests for renders that cross peer invalidations, covering full and postponed page shells, build output, local and remote data. The suite checks request timestamps, delayed invalidation, implicit path tags and lifetime boundaries. Six model tests run 180 seeds each, with the seed and operation trace in failure output. Memory invalidations are delivered to each process; Redis invalidations are written once and observed by peers.
The expiry regression fixed in #106 now runs as an ordinary passing test. One new expected failure records a Redis page lifetime discrepancy: a render starts at T, finishes about 1.2 seconds later, and writes with revalidate=2/expire=2. At T+2.1 seconds the handler still returns it because Redis TTL starts at write completion. This reproduction uses real clocks. It does not establish stale HTTP serving, since Next also receives cacheControl. Handler source is unchanged.
Validation: lint, formatting and typecheck pass. The targeted run reports 41 passing tests, including one expected failure, and 1,080 seeded scenarios across memory and Redis. The existing Redis integration CI matrix picks up the new suite. Run instructions are in docs/development.md. Deployment-ID and outage expansion were dropped from this work's scope; existing tests remain in place.