Skip to content

fix: isolate cache eviction registrations per entry - #25

Merged
mstuart merged 1 commit into
mainfrom
codex/daily-maintenance-20261017
Oct 17, 2026
Merged

mstuart merged 1 commit into
mainfrom
codex/daily-maintenance-20261017

Conversation

@mstuart

@mstuart mstuart commented Oct 17, 2026

Copy link
Copy Markdown
Owner
  • Keep stale finalization from evicting newer values. Deterministic finalization fixture deleted replacement entry and invoked its eviction callback.
  • Keep shared-value aliases independently registered. Deleting one alias unregistered both keys sharing an object, preventing automatic eviction of the other.
  • Allow typed array, function, and Date cache values. V extends Record<string, unknown> excluded runtime-supported object type arguments; declaration tests now cover these cases.

The implementation is limited to these behavior and declaration defects, with regression coverage. Finalization regressions use deterministic registry/WeakRef fixtures rather than relying on garbage collector timing. The existing default generic value type is preserved; explicit object type arguments are widened.

Validation: the original source fails the added runtime regression tests. The fixed branch passes 25 runtime tests, TypeScript declaration tests, repository lint, and git diff --check on Node.js 24.19.0. Node.js 22/24 CI and CodeQL are required before merging. No manual package release is included.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T22:26:17.356804Z 7259354 PR opened
🔒 Security Review ✅ Completed 2026-10-17T22:26:39.314267Z 7259354 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mstuart
mstuart merged commit 009479a into main Oct 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant