[context menu] Correct generated API metadata - #5523
Open
aarongarciah wants to merge 4 commits into
Open
Conversation
aarongarciah
added
docs
commit: |
Bundle size
PerformanceTotal duration: 1,130.70 ms 🔺+201.38 ms(+21.7%) | Renders: 92 (+0) | Paint: 1,877.72 ms 🔺+332.80 ms(+21.5%)
…and 6 more (+4 within noise) — details Metric alarms
…and 7 more metric alarms — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aarongarciah
force-pushed
the
agent/fix-context-menu-api-metadata
branch
from
August 17, 2026 11:24
63850bc to
b78a7cd
Compare
github-actions
Bot
added
the
PR: out-of-date
aarongarciah
force-pushed
the
agent/fix-context-menu-api-metadata
branch
from
August 17, 2026 16:42
b78a7cd to
9655d1b
Compare
github-actions
Bot
removed
the
PR: out-of-date
aarongarciah
force-pushed
the
agent/fix-context-menu-api-metadata
branch
from
August 18, 2026 10:31
8702a1f to
016562b
Compare
aarongarciah
marked this pull request as ready for review
August 18, 2026 10:35
aarongarciah
requested review from
atomiks,
colmtuite and
flaviendelangle
as code owners
August 18, 2026 10:35
aarongarciah
commented
Aug 18, 2026
| popupOpen = CommonTriggerDataAttributes.popupOpen, | ||
| /** | ||
| * Present when the trigger is pressed. | ||
| * Present when the corresponding context menu is open. |
Member
Author
There was a problem hiding this comment.
Currently both popupOpen and pressed are true when the popup is open i.e. pressed is the same as popupOpen in the current implementation.
Instead of changing the wording, we might want to fix the behavior so pressed means pressed.
cc @jjenzz
aarongarciah
commented
Aug 18, 2026
Comment on lines
+79
to
+83
| /** | ||
| * @ignore | ||
| * @deprecated This prop has no effect on Context Menu. | ||
| */ | ||
| closeParentOnEsc?: Menu.Root.Props['closeParentOnEsc'] | undefined; |
Member
Author
There was a problem hiding this comment.
This seems a legit approach but let me know if we should introduce the deprecation in another PR.
aarongarciah
commented
Aug 18, 2026
Comment on lines
+42
to
+46
| /** | ||
| * @ignore | ||
| * @deprecated This prop has no effect on Context Menu. | ||
| */ | ||
| positionMethod?: MenuPositionerProps['positionMethod'] | undefined; |
Member
Author
There was a problem hiding this comment.
github-actions
Bot
added
the
PR: out-of-date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Positionerdocumentation and type facade while retaining the shared Menu runtime implementationContextMenu.Positioner.Statein render callback signaturessideandaligndefaults at the shared Menu API surfaceSubmenuTrigger.openOnHoverdefaultWhy
The Context Menu API generator reused the Menu Positioner symbol, so it documented Menu defaults such as trigger anchoring, absolute positioning, and center alignment instead of Context Menu's pointer anchor, fixed positioning, and start alignment.
The facade overrides metadata only where Context Menu behavior or terminology differs. Shared runtime behavior, state, collision behavior, data attributes, and CSS variables continue to come from their canonical declarations.
This is a documentation and type-surface correction; it does not change runtime positioning behavior.