Skip to content

[tabs] Add generic value typing to Root - #5568

Draft
lyzno1 wants to merge 1 commit into
mui:masterfrom
lyzno1:codex/tabs-root-generic-value
Draft

[tabs] Add generic value typing to Root#5568
lyzno1 wants to merge 1 commit into
mui:masterfrom
lyzno1:codex/tabs-root-generic-value

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Fixes #5516.

Makes Tabs.Root generic over its value type so value, defaultValue, and onValueChange stay aligned through inference or an explicit generic.

Keeps Tabs.Tab, Tabs.Panel, and the internal context permissive. onValueChange remains nullable to match the existing automatic fallback behavior.

@pkg-pr-new

pkg-pr-new Bot commented Aug 25, 2026

Copy link
Copy Markdown

commit: edeb696

@code-infra-dashboard

code-infra-dashboard Bot commented Aug 25, 2026

Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@base-ui/react 0B(0.00%) 0B(0.00%)

Details of bundle changes

Performance

Total duration: 1,516.81 ms 🔺+442.36 ms(+41.2%) | Renders: 76 (+0) | Paint: 2,454.92 ms 🔺+720.36 ms(+41.5%)

Test Duration Renders
Tabs mount (200 instances) 302.18 ms 🔺+97.90 ms(+47.9%) 3 (+0)
Select mount (200 instances) 193.22 ms 🔺+68.52 ms(+54.9%) 3 (+0)
Menu mount (300 instances) 128.53 ms 🔺+56.71 ms(+78.9%) 1 (+0)
Slider mount (300 instances) 163.97 ms 🔺+53.73 ms(+48.7%) 2 (+0)
Scroll Area mount (300 instances) 99.45 ms 🔺+41.79 ms(+72.5%) 3 (+0)

…and 8 more (+2 within noise) — details

Metric alarms

Test Metric Change
Tabs mount (200 instances) bench:paint 🔺 +122.19 ms
Select mount (200 instances) bench:paint 🔺 +92.89 ms
Menu mount (300 instances) bench:paint 🔺 +83.82 ms
Slider mount (300 instances) bench:paint 🔺 +94.44 ms
Scroll Area mount (300 instances) bench:paint 🔺 +53.54 ms

…and 13 more metric alarms — details


Check out the code infra dashboard for more information about this PR.

@netlify

netlify Bot commented Aug 25, 2026

Copy link
Copy Markdown

Deploy Preview for base-ui ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit edeb696
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a8d93a54f057f0008ade2ec
😎 Deploy Preview https://deploy-preview-5568--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tabs] Consider generic value typing for Root

1 participant