[field] Publish neutral validity while async validation is in flight - #5600
Open
atomiks wants to merge 5 commits into
Open
[field] Publish neutral validity while async validation is in flight#5600atomiks wants to merge 5 commits into
atomiks wants to merge 5 commits into
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,224.35 ms 🔺+258.15 ms(+26.7%) | Renders: 76 (+0) | Paint: 1,960.74 ms 🔺+403.68 ms(+25.9%)
…and 5 more (+5 within noise) — details Metric alarms
…and 10 more metric alarms — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
marked this pull request as ready for review
August 31, 2026 07:26
atomiks
requested review from
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
August 31, 2026 07:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While an async
validatefunction is in flight, the field publisheddata-valid(a fresh all-clear from native constraints) even though the result is unknown, and onlyvalidationMode="onSubmit"retired the previous result. It also dropped known native failures in that window, so arequiredortype="email"field could submit past its native constraint when paired with an async validator.The pending window now maps to the existing neutral state (
valid: null, nodata-valid/data-invalid/aria-invalid), consistently across modes. The only results kept mid-flight are the ones the form must read synchronously to block submission:onChange/onBlur(async results can't block inonSubmitmode, per thevalidatedocs)A previously valid result retires in every mode, so no stale success shows for a value that was never validated.
publish/makeValidityDataacceptvalid: nullinternally; public types already allowed it.