Skip to content

[code-infra] Move dashboard repo settings to repositories #1649

Description

@Janpot

Currently code infra dashboard config is held in a single file. We could move this as a config file to the repos themselves and read on startup.

Open question: how to deal with function arguments? The dashboard will have to evaluate this module, what imports should it support? It'll also pose the risk that repos accidentally break pr comment generation with an invalid script. e.g. what if it imports another module, or a node module?

Is it possible to replace formatDocPath with a regex replacement config so it becomes json serializable. Then we express it as a .code-infra.json in the root and some of these problems go away.

Note

Let's put in backlog as a potential improvement until true good use-cases arise that benefit from it. in the meantime this method minimizes complexity in code infra dashboard. e.g. no need for fetching package list from the browser, or deal with network partition when fetching the config when the server is running. i.e. GH down would break the code infra dashboard.

Metadata

Metadata

Assignees

No one assigned

    Labels

    scope: code-infraInvolves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).type: enhancementIt’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions