You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently code infra dashboard config is held in a single file. We could move this as a config file to the repos themselves and read on startup.
Open question: how to deal with function arguments? The dashboard will have to evaluate this module, what imports should it support? It'll also pose the risk that repos accidentally break pr comment generation with an invalid script. e.g. what if it imports another module, or a node module?
Is it possible to replace formatDocPath with a regex replacement config so it becomes json serializable. Then we express it as a .code-infra.json in the root and some of these problems go away.
Note
Let's put in backlog as a potential improvement until true good use-cases arise that benefit from it. in the meantime this method minimizes complexity in code infra dashboard. e.g. no need for fetching package list from the browser, or deal with network partition when fetching the config when the server is running. i.e. GH down would break the code infra dashboard.
Currently code infra dashboard config is held in a single file. We could move this as a config file to the repos themselves and read on startup.
Open question: how to deal with function arguments? The dashboard will have to evaluate this module, what imports should it support? It'll also pose the risk that repos accidentally break pr comment generation with an invalid script. e.g. what if it imports another module, or a node module?
Is it possible to replace
formatDocPathwith a regex replacement config so it becomes json serializable. Then we express it as a.code-infra.jsonin the root and some of these problems go away.Note
Let's put in backlog as a potential improvement until true good use-cases arise that benefit from it. in the meantime this method minimizes complexity in code infra dashboard. e.g. no need for fetching package list from the browser, or deal with network partition when fetching the config when the server is running. i.e. GH down would break the code infra dashboard.