[test] Fix act warnings in the data source filter tests (#23360)

Author: JCQuintas

packages/x-data-grid-pro/src/tests/dataSource.DataGridPro.test.tsx

@@ -12,7 +12,7 @@ import type {
   GridLogicOperator,
 } from '@mui/x-data-grid-pro';
 import { spy } from 'sinon';
-import { getRow, sleep } from 'test/utils/helperFn';
+import { actSleep, getRow } from 'test/utils/helperFn';
 import { TestCache } from '@mui/x-data-grid/internals';
 
 describe('<DataGridPro /> - Data source', () => {
@@ -99,7 +99,7 @@ describe('<DataGridPro /> - Data source', () => {
       });
 
       await upsertFilterItem({ id: 2, field: 'id', operator: 'contains' });
-      await sleep(50);
+      await actSleep(50);
 
       expect(fetchRowsSpy.callCount).to.equal(2);
       expect(fetchRowsSpy.lastCall.args[0].filterModel.items).to.have.length(1);
@@ -143,7 +143,7 @@ describe('<DataGridPro /> - Data source', () => {
       await act(async () => {
         apiRef.current!.setFilterLogicOperator('or' as GridLogicOperator);
       });
-      await sleep(50);
+      await actSleep(50);
 
       expect(fetchRowsSpy.callCount).to.equal(2);
     });
@@ -163,7 +163,7 @@ describe('<DataGridPro /> - Data source', () => {
       await act(async () => {
         apiRef.current!.setFilterLogicOperator('or' as GridLogicOperator);
       });
-      await sleep(50);
+      await actSleep(50);
       expect(fetchRowsSpy.callCount).to.equal(2);
 
       await upsertFilterItem({ id: 2, field: 'id', operator: 'contains', value: '2' });

packages/x-data-grid-pro/src/tests/dataSourceLazyLoader.DataGridPro.test.tsx

@@ -1,7 +1,7 @@
 import * as React from 'react';
 import { useMockServer } from '@mui/x-data-grid-generator';
 import { act, createRenderer, waitFor, within } from '@mui/internal-test-utils';
-import { getCell, getRow, sleep } from 'test/utils/helperFn';
+import { actSleep, getCell, getRow } from 'test/utils/helperFn';
 import type { RefObject } from '@mui/x-internals/types';
 import { DataGridPro, useGridApiRef, GRID_ROOT_GROUP_ID } from '@mui/x-data-grid-pro';
 import type {
@@ -170,7 +170,7 @@ describe.skipIf(isJSDOM)('<DataGridPro /> - Data source lazy loader', () => {
       });
 
       await upsertFilterItem({ id: 1, field: 'id', operator: 'contains' });
-      await sleep(50);
+      await actSleep(50);
 
       expect(fetchRowsSpy.callCount).to.equal(1);
     });

packages/x-data-grid-pro/src/tests/dataSourceTreeData.DataGridPro.test.tsx

@@ -12,7 +12,7 @@ import type {
   GridGroupNode,
 } from '@mui/x-data-grid-pro';
 import { spy } from 'sinon';
-import { getCell, getRow, sleep } from 'test/utils/helperFn';
+import { actSleep, getCell, getRow } from 'test/utils/helperFn';
 import { isJSDOM } from 'test/utils/skipIf';
 
 const dataSetOptions = {
@@ -180,7 +180,7 @@ describe.skipIf(isJSDOM)('<DataGridPro /> - Data source tree data', () => {
       await act(async () => {
         apiRef.current!.upsertFilterItem({ id: 1, field: 'name', operator: 'contains' });
       });
-      await sleep(50);
+      await actSleep(50);
 
       expect(fetchRowsSpy.callCount).to.equal(1);
     });

packages/x-data-grid/src/tests/dataSource.DataGrid.test.tsx

@@ -13,7 +13,7 @@ import type {
   GridGetRowsResponse,
 } from '@mui/x-data-grid';
 import { spy } from 'sinon';
-import { getCell, sleep } from 'test/utils/helperFn';
+import { actSleep, getCell } from 'test/utils/helperFn';
 import { getKeyDefault } from '../hooks/features/dataSource/cache';
 import { TestCache } from '../internals/utils';
 
@@ -235,7 +235,7 @@ describe('<DataGrid /> - Data source', () => {
       await renderAndWaitForInitialFetch();
 
       await upsertFilterItem({ id: 1, field: 'id', operator: 'contains' });
-      await sleep(50);
+      await actSleep(50);
 
       expect(fetchRowsSpy.callCount).to.equal(1);
     });
@@ -244,7 +244,7 @@ describe('<DataGrid /> - Data source', () => {
       await renderAndWaitForInitialFetch();
 
       await upsertFilterItem({ id: 1, field: 'id', operator: 'contains' });
-      await sleep(50);
+      await actSleep(50);
       expect(fetchRowsSpy.callCount).to.equal(1);
 
       await upsertFilterItem({ id: 1, field: 'id', operator: 'contains', value: '1' });
@@ -280,7 +280,7 @@ describe('<DataGrid /> - Data source', () => {
       await act(async () => {
         apiRef.current!.setFilterLogicOperator('or' as GridLogicOperator);
       });
-      await sleep(50);
+      await actSleep(50);
 
       expect(fetchRowsSpy.callCount).to.equal(2);
     });
@@ -291,7 +291,7 @@ describe('<DataGrid /> - Data source', () => {
       await act(async () => {
         apiRef.current!.setQuickFilterValues(['']);
       });
-      await sleep(50);
+      await actSleep(50);
 
       expect(fetchRowsSpy.callCount).to.equal(1);
     });
@@ -312,7 +312,7 @@ describe('<DataGrid /> - Data source', () => {
           quickFilterLogicOperator: 'or' as GridLogicOperator,
         });
       });
-      await sleep(50);
+      await actSleep(50);
 
       expect(fetchRowsSpy.callCount).to.equal(2);
     });

test/utils/helperFn.ts

@@ -50,6 +50,13 @@ export function microtasks() {
   return act(() => Promise.resolve()) as unknown as Promise<void>;
 }
 
+// `sleep` inside `act`, so updates settling during the wait don't warn about missing `act`.
+export async function actSleep(duration: number) {
+  await act(async () => {
+    await sleep(duration);
+  });
+}
+
 export function spyApi(api: GridApiCommon, methodName: string) {
   const methodKey = methodName as keyof GridApiCommon;
   const privateApi = unwrapPrivateAPI(api);