fix: pin zora to 6.0.0 in test importmaps - #252
Merged
Conversation
|
@spuppo-mux is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Jerricho93
approved these changes
Jul 27, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI is broken repo-wide: unpinned zora CDN import now pulls a Node-only bundle.
All browser tests fail on any PR. Our test pages load
zorafrom an unversioned jsDelivr URL, which resolves tolatest. zora6.0.4(published 2026-07-12) added a bare Node import to its browser bundle, so the module graph fails to load and every test page times out.Repro
Any PR. Example: https://github.com/muxinc/media-elements/actions/runs/30292383359/job/90064977607
Cause
Every test page imports:
zora@6.0.4'sdist/index.jsnow begins:Browsers can't resolve
node:util, so the import fails before any test executes:zora@6.0.0— the version CI resolved to the last timemainwas green (2026-05-13) — has no such import. There are no intermediate releases; the registry only has6.0.0and6.0.4.zora
6.0.4declares nobrowserfield and no separate browser export condition, so there is no browser-safe entry point to switch to:Why the failing job name is misleading
Turbo reports whichever task fails first and then tears down the run, so the annotation names one arbitrary package:
Only 4 of 31 tasks completed. All 14 test pages are affected.
Affected files
packages/cloudflare-video-element/test/index.htmlpackages/custom-media-element/test/eager-upgrade.htmlpackages/custom-media-element/test/lazy-upgrade.htmlpackages/dash-video-element/test/index.htmlpackages/hls-video-element/test/index.htmlpackages/jwplayer-video-element/test/index.htmlpackages/media-tracks/test/index.htmlpackages/spotify-audio-element/test/index.htmlpackages/super-media-element/test/lazy.htmlpackages/tiktok-video-element/test/index.htmlpackages/videojs-video-element/test/index.htmlpackages/vimeo-video-element/test/index.htmlpackages/wistia-video-element/test/index.htmlpackages/youtube-video-element/test/index.htmlFix
Pin the version in all 14 importmaps:
Note
Low Risk
Test harness CDN importmap changes only; no production runtime or library code is modified.
Overview
Pins the zora test runner CDN import to
zora@6.0.0in 14 package browser test HTML importmaps (replacing the unversioned jsDelivr URL).This avoids pulling zora 6.0.4, whose browser bundle imports
node:utiland breaks module loading in the browser, which was causing repo-wide CI browser test timeouts.Reviewed by Cursor Bugbot for commit 26f5c7d. Bugbot is set up for automated code reviews on this repo. Configure here.