Skip to content

fix: pin zora to 6.0.0 in test importmaps - #252

Merged
spuppo-mux merged 1 commit into
muxinc:mainfrom
spuppo-mux:fix/pin-zora-cdn-version
Jul 27, 2026
Merged

fix: pin zora to 6.0.0 in test importmaps#252
spuppo-mux merged 1 commit into
muxinc:mainfrom
spuppo-mux:fix/pin-zora-cdn-version

Conversation

@spuppo-mux

@spuppo-mux spuppo-mux commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

CI is broken repo-wide: unpinned zora CDN import now pulls a Node-only bundle.

All browser tests fail on any PR. Our test pages load zora from an unversioned jsDelivr URL, which resolves to latest. zora 6.0.4 (published 2026-07-12) added a bare Node import to its browser bundle, so the module graph fails to load and every test page times out.

Repro

Any PR. Example: https://github.com/muxinc/media-elements/actions/runs/30292383359/job/90064977607

Cause

Every test page imports:

"zora": "https://cdn.jsdelivr.net/npm/zora/dist/index.js"

zora@6.0.4's dist/index.js now begins:

import { styleText } from 'node:util';

Browsers can't resolve node:util, so the import fails before any test executes:

Access to script at 'node:util' from origin 'http://localhost:8000' has been blocked by CORS policy:
  Cross origin requests are only supported for protocol schemes: chrome, chrome-extension, chrome-untrusted, data, http, https, isolated-app.
Failed to load resource: net::ERR_FAILED

Timeout of 10000ms exceeded for URL: http://localhost:8000/test/

zora@6.0.0 — the version CI resolved to the last time main was green (2026-05-13) — has no such import. There are no intermediate releases; the registry only has 6.0.0 and 6.0.4.

zora 6.0.4 declares no browser field and no separate browser export condition, so there is no browser-safe entry point to switch to:

"exports": { ".": { "import": { "default": "./dist/index.js" }, "require": { "default": "./dist/index.cjs" } } }

Why the failing job name is misleading

Turbo reports whichever task fails first and then tears down the run, so the annotation names one arbitrary package:

media-tracks#test: command (.../packages/media-tracks) npm run test exited (1)
Tasks: 4 successful, 31 total

Only 4 of 31 tasks completed. All 14 test pages are affected.

Affected files

  • packages/cloudflare-video-element/test/index.html
  • packages/custom-media-element/test/eager-upgrade.html
  • packages/custom-media-element/test/lazy-upgrade.html
  • packages/dash-video-element/test/index.html
  • packages/hls-video-element/test/index.html
  • packages/jwplayer-video-element/test/index.html
  • packages/media-tracks/test/index.html
  • packages/spotify-audio-element/test/index.html
  • packages/super-media-element/test/lazy.html
  • packages/tiktok-video-element/test/index.html
  • packages/videojs-video-element/test/index.html
  • packages/vimeo-video-element/test/index.html
  • packages/wistia-video-element/test/index.html
  • packages/youtube-video-element/test/index.html

Fix

Pin the version in all 14 importmaps:

-"zora": "https://cdn.jsdelivr.net/npm/zora/dist/index.js"
+"zora": "https://cdn.jsdelivr.net/npm/zora@6.0.0/dist/index.js"

Note

Low Risk
Test harness CDN importmap changes only; no production runtime or library code is modified.

Overview
Pins the zora test runner CDN import to zora@6.0.0 in 14 package browser test HTML importmaps (replacing the unversioned jsDelivr URL).

This avoids pulling zora 6.0.4, whose browser bundle imports node:util and breaks module loading in the browser, which was causing repo-wide CI browser test timeouts.

Reviewed by Cursor Bugbot for commit 26f5c7d. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

@spuppo-mux is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io

snyk-io Bot commented Jul 27, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@spuppo-mux
spuppo-mux requested a review from Jerricho93 July 27, 2026 19:13
@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
media-elements-nextjs Ready Ready Preview, Comment Jul 27, 2026 7:22pm

Request Review

@spuppo-mux
spuppo-mux merged commit 89acaf4 into muxinc:main Jul 27, 2026
7 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 27, 2026
@github-actions github-actions Bot mentioned this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants