chore: bump node version for cd.yml - #254
Merged
Merged
Conversation
|
@spuppo-mux is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
luwes
pushed a commit
that referenced
this pull request
Aug 6, 2026
luwes
pushed a commit
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last release failed - https://github.com/muxinc/media-elements/actions/runs/30300436654/job/90092272004
Trying to fix the same way as it was done for elements.
Follow up:
The created releases were not pushed to npm registry so they would need to be rolled back and recreated or manually pushed.
Note
Medium Risk
Changes release-time Node version and how npm auth is supplied for publishes; misconfiguration could break CD or leave packages unpublished until follow-up.
Overview
Updates the CD workflow (
cd.yml) so lint, test, and release all run on Node 24 instead of 20, matching the fix used elsewhere after a failed release.The release job’s
npm exec -c publish-packagesstep no longer setsNODE_AUTH_TOKEN; publishing still usessetup-nodewith the npm registry URL and the job’s existingid-token: writepermission, which fits--provenancein the publish script.Reviewed by Cursor Bugbot for commit a2db881. Bugbot is set up for automated code reviews on this repo. Configure here.