Skip to content

chore: bump node version for cd.yml - #254

Merged
luwes merged 1 commit into
muxinc:mainfrom
spuppo-mux:chore/update-cd
Aug 6, 2026
Merged

chore: bump node version for cd.yml#254
luwes merged 1 commit into
muxinc:mainfrom
spuppo-mux:chore/update-cd

Conversation

@spuppo-mux

@spuppo-mux spuppo-mux commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Last release failed - https://github.com/muxinc/media-elements/actions/runs/30300436654/job/90092272004

Trying to fix the same way as it was done for elements.

Follow up:

The created releases were not pushed to npm registry so they would need to be rolled back and recreated or manually pushed.


Note

Medium Risk
Changes release-time Node version and how npm auth is supplied for publishes; misconfiguration could break CD or leave packages unpublished until follow-up.

Overview
Updates the CD workflow (cd.yml) so lint, test, and release all run on Node 24 instead of 20, matching the fix used elsewhere after a failed release.

The release job’s npm exec -c publish-packages step no longer sets NODE_AUTH_TOKEN; publishing still uses setup-node with the npm registry URL and the job’s existing id-token: write permission, which fits --provenance in the publish script.

Reviewed by Cursor Bugbot for commit a2db881. Bugbot is set up for automated code reviews on this repo. Configure here.

@spuppo-mux
spuppo-mux requested a review from luwes July 27, 2026 20:29
@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

@spuppo-mux is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io

snyk-io Bot commented Jul 27, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@luwes
luwes merged commit ca9ebde into muxinc:main Aug 6, 2026
5 of 6 checks passed
luwes pushed a commit that referenced this pull request Aug 6, 2026
luwes pushed a commit that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants