Merge pull request #157 from jurretanjamx/tests-show-up-in-gitlab

Update Testcase to expose Classname to be visible in Gitlab

Author: xiwenc

lint/lint.go

@@ -346,6 +346,12 @@ func evalTestsuite(rule Rule, modelSourcePath string, ignoreNoqa bool, useCache
 		testcases = append(testcases, *testcase)
 	}
 
+	// Set classname on all testcases for GitLab Suite column display
+	suiteName := fmt.Sprintf("%s - %s", rule.RuleNumber, rule.Title)
+	for i := range testcases {
+		testcases[i].Classname = suiteName
+	}
+
 	testsuite := &Testsuite{
 		Name:      rule.Path,
 		Tests:     len(testcases),

lint/lint_test.go

@@ -713,6 +713,67 @@ function rule(input) {
 	}
 }
 
+func TestEvalTestsuite_Classname(t *testing.T) {
+	tempDir := t.TempDir()
+
+	jsContent := `
+const metadata = {
+    title: "Test Classname Field",
+    custom: { rulenumber: "099_0007", input: ".*\\.yaml" }
+};
+
+function rule(input) {
+    return { allow: true, errors: [] };
+}
+`
+	jsPath := filepath.Join(tempDir, "classname_test.js")
+	err := os.WriteFile(jsPath, []byte(jsContent), 0644)
+	if err != nil {
+		t.Fatalf("Failed to write js file: %v", err)
+	}
+
+	// Create multiple test files
+	err = os.WriteFile(filepath.Join(tempDir, "input1.yaml"), []byte(`Name: "Test1"`), 0644)
+	if err != nil {
+		t.Fatalf("Failed to write yaml file: %v", err)
+	}
+	err = os.WriteFile(filepath.Join(tempDir, "input2.yaml"), []byte(`Name: "Test2"`), 0644)
+	if err != nil {
+		t.Fatalf("Failed to write yaml file: %v", err)
+	}
+
+	rule := Rule{
+		Path:        jsPath,
+		Title:       "Test Classname Field",
+		RuleNumber:  "099_0007",
+		Pattern:     ".*\\.yaml",
+		PackageName: jsPath,
+		Language:    LanguageJavascript,
+	}
+
+	result, err := evalTestsuite(rule, tempDir, false, false, nil, nil)
+	if err != nil {
+		t.Fatalf("Failed to evaluate testsuite: %v", err)
+	}
+
+	expectedClassname := "099_0007 - Test Classname Field"
+
+	// Verify all testcases have the classname field set correctly
+	if len(result.Testcases) == 0 {
+		t.Fatal("Expected at least one testcase")
+	}
+
+	for i, tc := range result.Testcases {
+		if tc.Classname == "" {
+			t.Errorf("Testcase %d (%s) has empty Classname field", i, tc.Name)
+		}
+		if tc.Classname != expectedClassname {
+			t.Errorf("Testcase %d (%s) has incorrect Classname: got %q, want %q",
+				i, tc.Name, tc.Classname, expectedClassname)
+		}
+	}
+}
+
 func TestParseRuleMetadata_JavascriptValidation(t *testing.T) {
 	tempDir := t.TempDir()
 

lint/types.go

@@ -19,12 +19,13 @@ type Testsuite struct {
 }
 
 type Testcase struct {
-	XMLName      xml.Name `xml:"testcase" json:"-"`
-	Name         string   `xml:"name,attr" json:"name"`
-	OriginalPath string   `xml:"originalPath,attr,omitempty" json:"originalPath,omitempty"`
-	Time         float64  `xml:"time,attr" json:"time"`
-	Failure      *Failure `xml:"failure,omitempty" json:"failure,omitempty"`
-	Skipped      *Skipped `xml:"skipped,omitempty" json:"skipped,omitempty"`
+	XMLName   xml.Name `xml:"testcase" json:"-"`
+	Name      string   `xml:"name,attr" json:"name"`
+	Classname string   `xml:"classname,attr,omitempty" json:"classname,omitempty"`
+  OriginalPath string   `xml:"originalPath,attr,omitempty" json:"originalPath,omitempty"`
+	Time      float64  `xml:"time,attr" json:"time"`
+	Failure   *Failure `xml:"failure,omitempty" json:"failure,omitempty"`
+	Skipped   *Skipped `xml:"skipped,omitempty" json:"skipped,omitempty"`
 }
 
 type Failure struct {