You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Any reading for the delay in the approval of this PR? I would very much like to use this code - but my codebase is already on Django 2.2 (and current Django is already Django 3.0). Can I help?
@benglewis the issue seems to be that there are changes requested 24 days ago, so it's upto the original author @mikeIFTS of this PR to fix these and then we should see it merged I hope.
I'm not sure if a fork is the right solution, perhaps helping on the project instead?
I do get it though, Django 1.11 LTS is out of support, getting 2.2 LTS support going should be the number one priority, nothing else really matters but to get off 1.11 LTS.
Hey @robvdl normally I would agree, however as the original maintainer within Pebble, I'd give my blessing to a fork. Simply put, I don't work at Pebble any more and I don't know any of the devs that work there, so I can't influence anything from my end.
Thanks @scott-w I'll have a talk with people from work on Monday. I am not currently using this but our team stumbled across it but couldn't use it due to lack of Django 2.2 support at the time so we didn't. It might be worth maintaining though, we are a company that uses Postgres a lot. I wouldn't just jump on it though, because I already maintain more than I can handle myself, know the feeling all too well.
@scott-w, Maybe we should add some kind of record about the fork from @mikicz in the README file?
To make it easier for people to find a supported fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #53
Minimal changes to get this package working with Django 2.2.10+
Sample CI Build is here: https://circleci.com/gh/IFTServices/django-pgviews/11?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link