Add new generic collections unit tests

[josesimoes]

Description

• Add new unit tests to cover Null reference exception thrown when using List.Add<T> Home#1821.

Motivation and Context

• Related with Null reference exception thrown when using List.Add<T> Home#1821.
• Required fixes to run this successfully added with Fix closed-generic .cctor ordering causing NullReferenceException nf-interpreter#3493.
• Related with Support for generics <T> Home#782.

How Has This Been Tested?

Screenshots

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue with code or algorithm)
• New feature (non-breaking change which adds functionality to code)
• Breaking change (fix or feature that would cause existing functionality to change)
• Config and build (change in the configuration and build system, has no impact on code or features)
• Dependencies (update dependencies and changes associated, has no impact on code or features)
• Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
• Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

• My code follows the code style of this project (only if there are changes in source code).
• My changes require an update to the documentation (there are changes that require the docs website to be updated).
• I have updated the documentation accordingly (the changes require an update on the docs in this repo).
• I have read the CONTRIBUTING document.
• I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
• I have added new tests to cover my changes.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 46686846-3284-4a31-9c96-3b3ece913265

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Added tests covering Add() behavior and state retention for static readonly List<int> and List<DummyClass> instances, along with a shared static holder for the lists.

Changes

Static list tests

Layer / File(s)	Summary
Static list state validation Tests/GenericCollections/ListTests.cs	StaticListHolder provides static readonly integer and reference-type lists; new tests verify counts and stored element values after Add() calls.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: Type: Unit Tests

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the added generic collections unit tests and stays concise.
Description check	✅ Passed	The description is clearly related to the test additions and their purpose.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[josesimoes]

Unit tests are supposed to fail on 1st pass.

[josesimoes]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Tests/GenericCollections/ListTests.cs`:
- Around line 1206-1231: Reset the mutable static state used by
List_StaticField_ValueType_Add and List_StaticField_ReferenceType_Add after each
test by clearing StaticListHolder.Numbers and StaticListHolder.Items. Preserve
StaticListHolder’s static field initializer and ensure cleanup runs even when
assertions fail, so retries and reruns start with empty lists.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2ffbf01e-adc9-456b-9d5d-ea64ce49caa1

📥 Commits

Reviewing files that changed from the base of the PR and between ca3606b and c345ce6.

📒 Files selected for processing (1)

• Tests/GenericCollections/ListTests.cs

[josesimoes]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud