Rewire VS 2022 extension to SDK build tasks (#933)

Author: josesimoes

Tools.BuildTasks-2019/ProcessResourceFiles.cs

@@ -3,6 +3,16 @@
 // Portions Copyright (c) Microsoft Corporation.  All rights reserved.
 // See LICENSE file in the project root for full license information.
 //
+// ******************************************************************************
+// ** IMPORTANT: THIS FILE IS DUPLICATED.                                      **
+// **                                                                           **
+// ** A modified copy exists in the nanoFramework SDK repo:                    **
+// **   nf-nanoFramework.Sdk / nanoFramework.Tools.BuildTasks /                **
+// **   ProcessResourceFiles.cs                                                 **
+// **                                                                           **
+// ** The SDK copy carries #if NETFRAMEWORK guards for cross-platform support.  **
+// ** Any logic change made here MUST be ported there, and vice-versa.         **
+// ******************************************************************************
 
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;

Tools.BuildTasks-2019/Utilities/DebuggerHelper.cs

@@ -33,13 +33,13 @@ public static void WaitForDebuggerIfEnabled(string varName, int timeoutSeconds =
                     );
 
                 // wait N seconds for debugger to attach
-                while (!Debugger.IsAttached && waitForDebugToAttach.TotalSeconds > 0)
+                while (!System.Diagnostics.Debugger.IsAttached && waitForDebugToAttach.TotalSeconds > 0)
                 {
                     Thread.Sleep(1000);
                     waitForDebugToAttach -= TimeSpan.FromSeconds(1);
                 }
 
-                Debugger.Break();
+                System.Diagnostics.Debugger.Break();
             }
 #endif
         }

Tools.BuildTasks-2022/Properties/AssemblyInfo.cs

@@ -41,7 +41,7 @@
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x64'">
     <DebugSymbols>true</DebugSymbols>
     <OutputPath>bin\x64\Debug\</OutputPath>
-    <DefineConstants>TRACE;DEBUG;DEV17;</DefineConstants>
+    <DefineConstants>TRACE;DEBUG;DEV17</DefineConstants>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <DebugType>full</DebugType>
     <PlatformTarget>AnyCPU</PlatformTarget>
@@ -50,7 +50,7 @@
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|x64'">
     <OutputPath>bin\x64\Release\</OutputPath>
-    <DefineConstants>TRACE;DEV17;</DefineConstants>
+    <DefineConstants>TRACE;DEV17</DefineConstants>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <Optimize>true</Optimize>
     <DebugType>pdbonly</DebugType>
@@ -63,7 +63,7 @@
     <DebugType>full</DebugType>
     <Optimize>false</Optimize>
     <OutputPath>bin\Debug\</OutputPath>
-    <DefineConstants>TRACE;DEBUG;DEV17;</DefineConstants>
+    <DefineConstants>TRACE;DEBUG;DEV17</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <DeployExtension>True</DeployExtension>
@@ -76,7 +76,7 @@
     <DebugType>pdbonly</DebugType>
     <Optimize>true</Optimize>
     <OutputPath>bin\Release\</OutputPath>
-    <DefineConstants>TRACE;DEV17;</DefineConstants>
+    <DefineConstants>TRACE;DEV17</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <CodeAnalysisRuleSet>
@@ -90,6 +90,9 @@
     <Compile Include="..\Tools.BuildTasks-2019\ProcessResourceFiles.cs">
       <Link>ResXFileCodeGenerator\ProcessResourceFiles.cs</Link>
     </Compile>
+    <Compile Include="..\Tools.BuildTasks-2019\Utilities\DebuggerHelper.cs">
+      <Link>DebuggerHelper.cs</Link>
+    </Compile>
     <Compile Include="NanoFrameworkMoniker.cs">
       <AutoGen>True</AutoGen>
       <DesignTime>True</DesignTime>
@@ -280,13 +283,6 @@
       <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
       <VSIXSubPath>ProjectTemplates</VSIXSubPath>
     </ProjectReference>
-    <ProjectReference Include="..\Tools.BuildTasks-2022\Tools.BuildTasks-2022.csproj">
-      <Project>{552c2500-2c53-4148-a422-0ed983ef135d}</Project>
-      <Name>Tools.BuildTasks-2022</Name>
-      <InstallRoot>MSBuild</InstallRoot>
-      <IncludeOutputGroupsInVSIX>BuiltProjectOutputGroup</IncludeOutputGroupsInVSIX>
-      <VSIXSubPath>nanoFramework\v1.0\</VSIXSubPath>
-    </ProjectReference>
   </ItemGroup>
   <ItemGroup>
     <Resource Include="Resources\DeviceDisconnected.16.16.png" />

Tools.BuildTasks-2022/Tools.BuildTasks-2022.csproj

@@ -1883,12 +1883,6 @@
           "Microsoft.VisualStudio.Interop": "17.13.40008"
         }
       },
-      "nanoFramework.Tools.BuildTasks": {
-        "type": "Project",
-        "dependencies": {
-          "Microsoft.Build.Framework": "[17.12.6, )",
-          "Microsoft.Build.Utilities.Core": "[17.11.4, )"
-        }
       }
     },
     ".NETFramework,Version=v4.7.2/win": {