Fixes and improvements in native socket (#3289)

***NO_CI***

Author: josesimoes

src/DeviceInterfaces/System.Net/sys_net_native.cpp

@@ -254,6 +254,7 @@ static const CLR_RT_MethodHandler method_lookup[] =
     NULL,
     NULL,
     NULL,
+    NULL,
     Library_sys_net_native_System_Security_Cryptography_X509Certificates_X509Certificate::ParseCertificate___STATIC__VOID__SZARRAY_U1__BYREF_STRING__BYREF_STRING__BYREF_SystemDateTime__BYREF_SystemDateTime,
     NULL,
     NULL,
@@ -345,9 +346,9 @@ static const CLR_RT_MethodHandler method_lookup[] =
 const CLR_RT_NativeAssemblyData g_CLR_AssemblyNative_System_Net =
 {
     "System.Net",
-    0xD82C1452,
+    0x6DFA71D6,
     method_lookup,
-    { 100, 2, 0, 11 }
+    { 100, 2, 0, 12 }
 };
 
 // clang-format on

src/DeviceInterfaces/System.Net/sys_net_native.h

@@ -333,9 +333,7 @@ struct Library_sys_net_native_System_Net_Sockets_Socket
     static const int FIELD__m_recvTimeout = 4;
     static const int FIELD__m_sendTimeout = 5;
     static const int FIELD___socketType = 6;
-    static const int FIELD___nonBlockingConnectInProgress = 7;
-    static const int FIELD___nonBlockingConnectRightEndPoint = 8;
-    static const int FIELD___rightEndPoint = 9;
+    static const int FIELD___rightEndPoint = 7;
 
     //--//
 };

src/DeviceInterfaces/System.Net/sys_net_native_System_Net_Sockets_NativeSocket.cpp

@@ -864,6 +864,11 @@ HRESULT Library_sys_net_native_System_Net_Sockets_NativeSocket::SendRecvHelper(
                 break;
             }
 
+            // yield to the CLR scheduler to prevent a tight loop when select reports ready
+            // but the actual send/recv returns EWOULDBLOCK (race with lwIP stack)
+            NANOCLR_CHECK_HRESULT(
+                g_CLR_RT_ExecutionEngine.WaitEvents(stack.m_owningThread, *timeout, Event_Socket, fRes));
+
             continue;
         }
         // zero recv bytes indicates the handle has been closed.

src/PAL/Lwip/lwIP_Sockets.cpp

@@ -1820,7 +1820,7 @@ int LWIP_SOCKETS_Driver::GetNativeError(int error)
             break;
 
         case ENOTCONN:
-            ret = SOCK_EISCONN;
+            ret = SOCK_ENOTCONN;
             break;
 
 #if !defined(__GNUC__) // same as ENOTSOCK for GCC

targets/ChibiOS/_include/lwipopts.h

@@ -485,6 +485,13 @@
 #define TCP_MSS 1480
 #endif
 
+/**
+ * TCP_SYNMAXRTX: Maximum number of retransmissions of SYN segments.
+ */
+#ifndef TCP_SYNMAXRTX
+#define TCP_SYNMAXRTX 4
+#endif
+
 /**
  * TCP_LISTEN_BACKLOG: Enable the backlog option for tcp listen pcb.
  */

targets/ESP32/_IDF/sdkconfig.default

@@ -55,6 +55,7 @@ CONFIG_LWIP_DHCPS=n
 CONFIG_LWIP_IPV6=n
 CONFIG_LWIP_MAX_LISTENING_TCP=8
 CONFIG_LWIP_SNTP_MAX_SERVERS=2
+CONFIG_LWIP_TCP_SYNMAXRTX=4
 
 CONFIG_MBEDTLS_DEFAULT_MEM_ALLOC=y
 CONFIG_MBEDTLS_SSL_VARIABLE_BUFFER_LENGTH=y

targets/ESP32/_IDF/sdkconfig.default.esp32c3

@@ -42,6 +42,7 @@ CONFIG_LWIP_DHCPS=n
 CONFIG_LWIP_IPV6=n
 CONFIG_LWIP_MAX_LISTENING_TCP=4
 CONFIG_LWIP_SNTP_MAX_SERVERS=2
+CONFIG_LWIP_TCP_SYNMAXRTX=4
 
 CONFIG_MBEDTLS_DEFAULT_MEM_ALLOC=y
 CONFIG_MBEDTLS_SSL_VARIABLE_BUFFER_LENGTH=y

targets/ESP32/_IDF/sdkconfig.default.esp32c5

@@ -55,6 +55,7 @@ CONFIG_LWIP_DHCP_OPTIONS_LEN=80
 CONFIG_LWIP_DHCPS=n
 CONFIG_LWIP_MAX_LISTENING_TCP=8
 CONFIG_LWIP_SNTP_MAX_SERVERS=2
+CONFIG_LWIP_TCP_SYNMAXRTX=4
 
 CONFIG_MBEDTLS_DEFAULT_MEM_ALLOC=y
 CONFIG_MBEDTLS_SSL_VARIABLE_BUFFER_LENGTH=y

targets/ESP32/_IDF/sdkconfig.default.esp32c6

@@ -50,6 +50,7 @@ CONFIG_LWIP_DHCP_OPTIONS_LEN=80
 CONFIG_LWIP_DHCPS=n
 CONFIG_LWIP_MAX_LISTENING_TCP=8
 CONFIG_LWIP_SNTP_MAX_SERVERS=2
+CONFIG_LWIP_TCP_SYNMAXRTX=4
 
 CONFIG_MBEDTLS_DEFAULT_MEM_ALLOC=y
 CONFIG_MBEDTLS_SSL_VARIABLE_BUFFER_LENGTH=y

targets/ESP32/_IDF/sdkconfig.default.esp32h2

@@ -115,6 +115,7 @@ CONFIG_LWIP_MAX_SOCKETS=16
 CONFIG_LWIP_SO_LINGER=y
 CONFIG_LWIP_SO_RCVBUF=y
 CONFIG_LWIP_DHCP_OPTIONS_LEN=80
+CONFIG_LWIP_TCP_SYNMAXRTX=4
 
 CONFIG_LITTLEFS_MAX_PARTITIONS=1
 CONFIG_LITTLEFS_OBJ_NAME_LEN=256