Cmr 10636 jn - #2280
Closed
indiejames wants to merge 4 commits into
Closed
Conversation
jceaser
reviewed
Aug 18, 2025
jceaser
reviewed
Aug 18, 2025
| (testing "Random/default indices should return non-gran cluster" | ||
| (let [random #{"some_index" "users" "metadata" ""}] | ||
| (doseq [index random] | ||
| (is (= non-gran-cluster (es-index/get-es-cluster-name-from-index-name index))))))) No newline at end of file |
Contributor
There was a problem hiding this comment.
you have a missing new line. Did you use vscode and the calva plugin?
Contributor
Author
There was a problem hiding this comment.
yes, vscode and calva
Contributor
Author
There was a problem hiding this comment.
not sure to which newline you are referring
Contributor
There was a problem hiding this comment.
the one at the end of the file, the (-).
jceaser
reviewed
Aug 18, 2025
| @@ -0,0 +1,69 @@ | |||
| # file: cmr.fish | |||
Contributor
There was a problem hiding this comment.
wait, there is another fish user on the project?
Contributor
Author
There was a problem hiding this comment.
sorry, this is a command completions file for using the cmr command in the fish shell. It's not important to your branch, I just used it as an opportunity to add it as mentioned in the README
(If you use a system shell not compatible with Bash, we accept Pull Requests for
new shells with auto-complete.)
jceaser
requested changes
Aug 18, 2025
jceaser
left a comment
jceaser
left a comment
Contributor
There was a problem hiding this comment.
I would like to know why your only matching 1_c.
jceaser
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature/fix?
Refactoring of function for determining proper cluster for a given index
Please summarize the feature or fix.
Refactoring of function for determining proper cluster for a given index
What is the Solution?
Refactoring of function for determining proper cluster for a given index
Summarize what you changed.
Refactoring of function for determining proper cluster for a given index.
Also added completion config file for fish shell users
What areas of the application does this impact?
List impacted areas.
indexer,search,acls,bootstrap
Checklist