CMR-10723 bump up urllib to a modern version - #2282
Merged
Merged
Conversation
jceaser
commented
Aug 19, 2025
| @@ -1,2 +1,2 @@ | |||
| urllib3==1.26.19 | |||
| urllib3~=2.5.0 | |||
Contributor
Author
There was a problem hiding this comment.
should support future versions as well
jceaser
commented
Aug 19, 2025
|
|
||
| pool_manager = urllib3.PoolManager(headers={"Authorization" : "mock-echo-system-token"}) | ||
| pool_manager = urllib3.PoolManager(headers={"Authorization" : "mock-echo-system-token", | ||
| "client-id": f'{__file__}'}) |
Contributor
Author
There was a problem hiding this comment.
everything we do should have a client-id so we can tell our traffic from random users.
jceaser
commented
Aug 19, 2025
| Takes the job details and builds the local job endpoint | ||
| """ | ||
| url = "http://{}:{}" | ||
| url = "http://{}:{}/{}" |
Contributor
Author
There was a problem hiding this comment.
no idea how this was working before
jceaser
commented
Aug 19, 2025
| hours = job_details["scheduling"]["timing"].get("hours", 0) | ||
| total_minutes = minutes + hours*60 | ||
| print("Scheduling job for every " + str(total_minutes) + " minutes") | ||
| logger.info("Scheduling job for every %d minutes", total_minutes) |
Contributor
Author
There was a problem hiding this comment.
pylint made me do it
jceaser
commented
Aug 19, 2025
| help='Do a test run of RefreashKMSCache and exit.') | ||
| args = parser.parse_args() | ||
|
|
||
| if args.test: |
Contributor
Author
There was a problem hiding this comment.
I needed a quick and dirty way to run the code and verify that urllib3 was functioning on the new version.
TylerHeald1
approved these changes
Aug 19, 2025
eereiter
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
url lib3 was outdated
What is the feature/fix?
Checklist