CMR-11368: Databine test improvements - #2472
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2472 +/- ##
==========================================
- Coverage 29.20% 29.19% -0.02%
==========================================
Files 1014 1014
Lines 71257 71257
Branches 1265 1265
==========================================
- Hits 20811 20800 -11
- Misses 49244 49255 +11
Partials 1202 1202 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e012631 to
7890190
Compare
05d57bc to
dd40499
Compare
| ["GUEST" "AG10000-PROV"] (concat guest-acls AG10000-acls) | ||
| ["AG12345-PROV" "AG10000-PROV"] (concat AG12345-acls AG10000-acls) | ||
| ["guest" "registered" "AG12345-PROV" "AG10000-PROV"] all-acls-no-admin)) | ||
| (u/without-publishing-messages |
There was a problem hiding this comment.
this was a suggestion to prevent expected exceptions from showing up in the logs
| (finally | ||
| ;; always re-enable writes for access control service | ||
| (u/enable-access-control-writes post-options) | ||
| (Thread/sleep 500)))) |
There was a problem hiding this comment.
Try/finally was added to ensure that the services was always put back into read/write mode so that other tests could pass. This allows other tests to continue to run and not fail incorrectly. A delay was added to ensure the other service has time to take effect.
This is one of the intermittent errors we would get.
| (finally | ||
| ;; Allways re-eneable writes for access control service, even if there was an exception | ||
| (u/enable-access-control-writes post-options) | ||
| (Thread/sleep 500)))) |
There was a problem hiding this comment.
Try/finally was added to ensure that the services was always put back into read/write mode so that other tests could pass. This allows other tests to continue to run and not fail incorrectly. A delay was added to ensure the other service has time to take effect.
This is one of the intermittent errors we would get.
| (has-action-permission? (url/enable-access-control-writes-url) :post admin-read-update-token) | ||
| (has-action-permission? (url/enable-email-subscription-processing) :post admin-read-update-token) | ||
| ;; Give the servers time set | ||
| (Thread/sleep 500))))) |
There was a problem hiding this comment.
Try/finally was added to ensure that the services was always put back into read/write mode so that other tests could pass. This allows other tests to continue to run and not fail incorrectly. A delay was added to ensure the other service has time to take effect.
This is one of the intermittent errors we would get.
jceaser
changed the title
| {:revision-date-range "2000-01-01T10:00:00Z,2010-03-10T12:00:00Z"})) | ||
| (finally | ||
| ;; Always guarantee writes are re-enabled after this test suite! | ||
| (has-action-permission? (url/enable-ingest-writes-url) :post admin-read-update-token) |
There was a problem hiding this comment.
if a 401 is returned when enabling one of these features I think it would do so silently as written. That may not be likely, but I think adding a check on the response and having a message that lets us know that one of the features failed to be re-enabled and would make it easier to diagnose if there are test failures due to a features not being enabled in the future.
I don't see this as a blocking issue, but wanted to share the feedback.
…ge write status better
…ing the other testing threads
9befe60 to
211e67f
Compare
5 participants
Overview
Background
This ticket started out as a Snyk ticket, however Jackson had a lot of issues and another ticket ended up applying the needed library change. In the course of doing the work to support 2.21.5 severely intermittent test issues prevented this ticket from being properly tested in bamboo and it was decided to fix those issues.
What are the changes?
What areas of the application does this impact?
Required Checklist