CMR-11452 - Remove hour break down in bulk-index/after-date-time & bulk-index/between-date-time to improve performance - #2487
Merged
Merged
Conversation
…nd bulk-index/between-date-time
…ed support for header override to allow any size window
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2487 +/- ##
==========================================
- Coverage 57.97% 57.96% -0.02%
==========================================
Files 1074 1074
Lines 74718 74707 -11
Branches 2197 2190 -7
==========================================
- Hits 43316 43302 -14
- Misses 29354 29356 +2
- Partials 2048 2049 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jaortega527
requested review from
daniel-zamora,
jceaser,
jmaeng72 and
zimzoom
August 24, 2026 16:48
jmaeng72
reviewed
Aug 25, 2026
|
|
||
| (defn- ignore-after-date-time-limit? | ||
| [headers] | ||
| (= "true" |
Contributor
There was a problem hiding this comment.
why compare string instead of bool?
Contributor
Author
There was a problem hiding this comment.
That's a good point. I updated to use parseBoolean.
jmaeng72
reviewed
Aug 25, 2026
jmaeng72
approved these changes
Aug 25, 2026
…ange is too large
…ing string comparison
eereiter
approved these changes
Aug 28, 2026
isja17
pushed a commit
that referenced
this pull request
Aug 31, 2026
…lk-index/between-date-time to improve performance (#2487) * CMR-11452 - Removed hour "chunking" from bulk-index/after-date-time and bulk-index/between-date-time * CMR-11452 - Updated default max window to 720 hours (30 days) and added support for header override to allow any size window * CMR-11452 - Small improvement to error message when after_date_time range is too large * CMR-11452 - Update header retrieval to use parseBoolean instead of using string comparison
isja17
pushed a commit
that referenced
this pull request
Aug 31, 2026
…lk-index/between-date-time to improve performance (#2487) * CMR-11452 - Removed hour "chunking" from bulk-index/after-date-time and bulk-index/between-date-time * CMR-11452 - Updated default max window to 720 hours (30 days) and added support for header override to allow any size window * CMR-11452 - Small improvement to error message when after_date_time range is too large * CMR-11452 - Update header retrieval to use parseBoolean instead of using string comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What are the changes?
/bulk-index/after-date-timeand/bulk-index/between-date-timeto send one full daterange reindexing event per provider instead of chunking the events by hour.bulk-index/after-date-timerange limit from 7 days to 30 daysCMR-Bulk-Index-Ignore-Time-Range-Limit: trueto bypass thebulk-index/after-date-timerange limitWhat areas of the application does this impact?
Required Checklist
Additional Checklist