[pre-commit.ci] pre-commit autoupdate - #305
Conversation
aee5000 to
1680f56
Compare
1680f56 to
9c96cc8
Compare
9c96cc8 to
6d0ae55
Compare
|
There's actually a decent change to ruff in 0.16.x, and it's probably fine, but I want to make sure we don't break everything for folks who are just making a small change before merging this. Update: So updating to this version will enable a bunch of rules that aren't currently enabled. It can be easily set back to the old way if people complain. And I verified that only the files that are touched in a PR need to be fixed with the pre-commit ci. So I recommend we go ahead and upgrade now. |
6d0ae55 to
e8f57a7
Compare
be0ad4b to
e2e8961
Compare
cb0ab25 to
29c89f0
Compare
|
Just FYI'ing you for a sanity check. This allows us to update ruff now, and fix problems later. The change to v0.16 was significant and I didn't want to go and update each project in one go. By adding a .ruff.toml and using the selected values, I set the tests to what was there originally as listed in the ruff migration guide. I will probably do some test migrations for regression tests that I own before taking on anyone else's. But to migrate a single test at a time, we can push down new .ruff.toml files into sub dirs. so one in tests/hoss would set the rules for just the hoss directory. I think this is a good plan since I didn't get this done in the IP. |
flamingbear
left a comment
There was a problem hiding this comment.
I'm good with this, but I wrote most of it.
updates: - [github.com/astral-sh/ruff-pre-commit: v0.15.21 → v0.16.5](astral-sh/ruff-pre-commit@v0.15.21...v0.16.5)
ea81fb4 to
5db420e
Compare
updates: