Skip to content

[pre-commit.ci] pre-commit autoupdate - #305

Open
pre-commit-ci[bot] wants to merge 1 commit into
mainfrom
pre-commit-ci-update-config
Open

[pre-commit.ci] pre-commit autoupdate#305
pre-commit-ci[bot] wants to merge 1 commit into
mainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci

@pre-commit-ci pre-commit-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@pre-commit-ci
pre-commit-ci Bot requested review from a team, flamingbear and owenlittlejohns as code owners July 20, 2026 21:49
@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from aee5000 to 1680f56 Compare July 27, 2026 21:37
@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 1680f56 to 9c96cc8 Compare August 3, 2026 22:00
@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 9c96cc8 to 6d0ae55 Compare August 10, 2026 22:02
@flamingbear

flamingbear commented Aug 12, 2026

Copy link
Copy Markdown
Member

There's actually a decent change to ruff in 0.16.x, and it's probably fine, but I want to make sure we don't break everything for folks who are just making a small change before merging this.

Update: So updating to this version will enable a bunch of rules that aren't currently enabled.

Ruff now enables 413 rules by default, up from 59 in previous versions.

It can be easily set back to the old way if people complain.

[lint]
select = ["E4", "E7", "E9", "F"]

And I verified that only the files that are touched in a PR need to be fixed with the pre-commit ci. So I recommend we go ahead and upgrade now.

@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 6d0ae55 to e8f57a7 Compare August 17, 2026 22:27
flamingbear
flamingbear previously approved these changes Aug 17, 2026

@flamingbear flamingbear left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think this is good I may have been too optimistic before, the pre-commit ci is showing lots of changes. It will need more than just an update.

@flamingbear
flamingbear self-requested a review August 17, 2026 23:58
@flamingbear
flamingbear dismissed their stale review August 17, 2026 23:58

pre-commit ci

@flamingbear flamingbear added the pre-commit.ci autofix free the :robot: label Aug 18, 2026
@pre-commit-ci pre-commit-ci Bot removed the pre-commit.ci autofix free the :robot: label Aug 18, 2026
@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from be0ad4b to e2e8961 Compare August 24, 2026 21:57
@flamingbear flamingbear added the pre-commit.ci autofix free the :robot: label Aug 26, 2026
@pre-commit-ci pre-commit-ci Bot removed the pre-commit.ci autofix free the :robot: label Aug 26, 2026
@flamingbear
flamingbear force-pushed the pre-commit-ci-update-config branch from cb0ab25 to 29c89f0 Compare August 26, 2026 21:24
@flamingbear

Copy link
Copy Markdown
Member

@owenlittlejohns

Just FYI'ing you for a sanity check. This allows us to update ruff now, and fix problems later. The change to v0.16 was significant and I didn't want to go and update each project in one go. By adding a .ruff.toml and using the selected values, I set the tests to what was there originally as listed in the ruff migration guide.

I will probably do some test migrations for regression tests that I own before taking on anyone else's. But to migrate a single test at a time, we can push down new .ruff.toml files into sub dirs. so one in tests/hoss would set the rules for just the hoss directory.

I think this is a good plan since I didn't get this done in the IP.

@flamingbear flamingbear left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, but I wrote most of it.

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.15.21 → v0.16.5](astral-sh/ruff-pre-commit@v0.15.21...v0.16.5)
@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from ea81fb4 to 5db420e Compare August 31, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant