Repository navigation
Fix picture markers overlaying auto-generated initials - #227
Merged
Merged
Conversation
v1.14 started drawing a label banner on every picture marker because hasLabel treated the initials title as requested text. Restore the v1.13.1 photo-only default: overlay only when prefix, suffix, or an explicit label is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #197.
v1.14 (#172) added a label banner on picture markers. The condition was:
```js
const hasLabel = this.title && (this.prefix || this.suffix || this.title.trim());
```
`title` is the auto-generated initials (e.g. `KL`), so every entity picture got initials drawn over the photo. That matches the double-`KL` reports vs v1.13.1.
Changes
`display: icon` / `state` / `attribute` are unchanged.